fix: stop revalidating with stale values #8193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oops! Looks like you forgot to update the changelog. When updating CHANGELOG.md, please consider the following:
|
tahmidrahman-dsi
approved these changes
Dec 11, 2024
naftis
reviewed
Dec 11, 2024
Comment on lines
+287
to
288
| setFieldTouched(fieldDefinition.name, true, false) | ||
| setFieldValue(fieldDefinition.name, files) |
There was a problem hiding this comment.
Good fix and a good comment. Just to understand the issue, as setFieldValue and setFieldTouched are promises, would one fix also be to await for the setFieldValue and then setFieldTouched, or why does setFieldTouched have stale values?
There was a problem hiding this comment.
My guess is that if your validate function was asynchronous then promises would have come into play
naftis
approved these changes
Dec 11, 2024
Zangetsu101
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.