Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Router testing #8138

Closed
wants to merge 47 commits into from
Closed

Router testing #8138

wants to merge 47 commits into from

Conversation

makelicious
Copy link
Collaborator

No description provided.

makelicious and others added 30 commits November 25, 2024 16:55
@makelicious
chore: upgrade to react-router-dom without navigation
e53c175
@makelicious
chore: move navigation out of redux which are not bound to other redu…
0e6eb22 
…cers

Few actions like 'navigation/GO_TO_PAGE' are used elsewhere
@makelicious
chore(react-router): upgrade goto and gotogroup actions
d0a2ab0
@makelicious
chore: remove unused types and comments
d07ce24
@makelicious
chore: remove search param types from common api
9c7cae6
@makelicious
fix(navigation): use formatUrl to fix organisation link
e3e9a6c
@makelicious
fix(navigation): fix broken links. Clean up types and comments
74e62ad
@makelicious
fix(navigation): clean unnecessary comments
9ddd5e0
@makelicious
Merge branch 'develop' into chore/upgrade-react-router-dom
6e789eb
@makelicious
fix: conflict mistakes
365b5a4 
remove unneeded methods from interface, remove unused component
@makelicious
chore: replace test router with memoryrouter, update partially tests
17ffc19
@rikukissa
fix OfficeHome and ViewRecord test suites
2e5f744
@rikukissa
WIP
d21d694
@makelicious
fix(tests): fix compile errors. use v6 route instead of history in tests
3ebb7c0
@makelicious
fix(tests): remove commented out code
ad169d1
@makelicious
fix(tests): add missing license header
5aaa6b5
@makelicious
fix(tests): remove history and use memory router instead on tests
0f8946d
@makelicious
fix: take off warning limit to run tests on CI
3859638
@makelicious
wip: continue updating router tests
462b5ee
@rikukissa
update create new user tests
e0a1563
@makelicious
fix: router tests
e7feda7
@rikukissa
setup App.tsx as a router config object
324c1a3
@rikukissa
Merge branch 'router-testing' of github.com:opencrvs/opencrvs-core in…
25d5e2f 
…to router-testing
@makelicious
fix: update previewform tests
912f53e
@rikukissa
fix DeclationFormTest
15799db
@rikukissa
Merge branch 'router-testing' of github.com:opencrvs/opencrvs-core in…
019b352 
…to router-testing
@rikukissa
fix SelectVitalEvent
acf2845
@rikukissa
fix ReviewForm tests
f9fc0a5
@rikukissa
fix naming of withRouter
4ad904d
@makelicious
fix(test): render selected path and node instead of routes
195d4e1
makelicious and others added 17 commits December 2, 2024 17:50
@makelicious
fix: update imports
613dbda
@makelicious
fix: fix missing paths and routes
5fcd9ac
@rikukissa
fix two tests
3072765
@rikukissa
Merge branch 'router-testing' of github.com:opencrvs/opencrvs-core in…
b536d38 
…to router-testing
@makelicious
fix: add path to UserList tests
1fd82c2
@makelicious
fix: move dispatches to top on AdvancedSearchResult.test.tsx
40a0126
@rikukissa
cleanup
20765e0
@makelicious
debug: skip two tests to see CI run
aeb1b9e
@makelicious
chore: change router hoc name
d470402 
file is referenced by two casings and it creates issues with git
@makelicious
chore: clean up unused definitions
7339728
@makelicious
fix: change collector form route in test
b1dbc54
@makelicious
fix: flush promises on tests that fail on CI
f0464eb
@makelicious
fix: add back missing routes
61f76b9
@makelicious
fix: revert create new user component refactoring
bdd8f7e 
Seems that creation does not work as intented
@makelicious
fix: send actions through reducer rather than on component
abbef8a 
initially changed due removal of router navigation from state
@makelicious
Merge branch 'develop' into router-testing
29f1bed
@makelicious
fix: use navigate in v2 events
d0bfb84
@makelicious makelicious changed the base branch from chore/upgrade-react-router-dom to develop December 3, 2024 12:15
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 3, 2024

Oops! Looks like you forgot to update the changelog. When updating CHANGELOG.md, please consider the following:

  • Changelog is read by country implementors who might not always be familiar with all technical details of OpenCRVS. Keep language high-level, user friendly and avoid technical references to internals.
  • Answer "What's new?", "Why was the change made?" and "Why should I care?" for each change.
  • If it's a breaking change, include a migration guide answering "What do I need to do to upgrade?".

@makelicious makelicious added the 🚀 Ready to deploy Deployment automation should pick this PR up and start auto-deploying it label Dec 3, 2024
@makelicious makelicious deployed to router-testing December 3, 2024 12:29 — with GitHub Actions Active
@ocrvs-bot
Copy link
Collaborator

Your environment is deployed to https://router-testing.opencrvs.dev

@makelicious makelicious closed this Dec 3, 2024
@makelicious makelicious removed the 🚀 Ready to deploy Deployment automation should pick this PR up and start auto-deploying it label Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@makelicious @ocrvs-bot @rikukissa