fix: Stops local sys admin from creating national level staff #8112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is better to have in the gateway since most of access mgnt is handled there already #7698
The way we were building the criteria object was buggy especially for when we are filtering based on user roles #7698
This is avoid users with lower roles creating or updating other users with higher roles #7698
This comment has been minimized.
This comment has been minimized.
Siyasanga
added
🚀 Ready to deploy
euanmillar
added
🚀 Ready to deploy
euanmillar
force-pushed
the
ocrvs-7698-2
branch
from
f451d90 to
00d19a6
Compare
This was referenced Dec 2, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stop sys admins from de-activating themselves and stop local sys admins. from creating national level users
Also stops sys admins from being able to delete themselves in the UI:
A National Sys Admin will see the correct roles available to them:
A local system admin will not see national level roles available to them:
