Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix spacing of Heading3 #8111

Merged
merged 1 commit into from
Dec 2, 2024
Merged

Fix spacing of Heading3 #8111

merged 1 commit into from
Dec 2, 2024

Conversation

euanmillar
Copy link
Collaborator

@euanmillar euanmillar commented Nov 29, 2024 •
edited
Loading

This change made the space above heading 3 and the border too tight compared to other components.

Before:
Screenshot 2024-11-29 at 14 31 37

When upgrading Niue and Uganda, it became clear so this change makes the space similar to other components:

After:
Screenshot 2024-11-29 at 14 28 16

For comparison with other components:
Screenshot 2024-11-29 at 14 28 26

@github-actions GitHub Actions
Copy link

Oops! Looks like you forgot to update the changelog. When updating CHANGELOG.md, please consider the following:

  • Changelog is read by country implementors who might not always be familiar with all technical details of OpenCRVS. Keep language high-level, user friendly and avoid technical references to internals.
  • Answer "What's new?", "Why was the change made?" and "Why should I care?" for each change.
  • If it's a breaking change, include a migration guide answering "What do I need to do to upgrade?".

@euanmillar euanmillar added this to the v1.6.1 milestone Nov 29, 2024
@Zangetsu101 Zangetsu101 added the 🚀 Ready to deploy Deployment automation should pick this PR up and start auto-deploying it label Dec 2, 2024
@Zangetsu101
Copy link
Collaborator

@jpye-finch Could you review this once it gets deployed please?

@github-actions github-actions bot deployed to heading-3-spacing December 2, 2024 12:05 Active
@ocrvs-bot
Copy link
Collaborator

Your environment is deployed to https://heading-3-spacing.opencrvs.dev

tumbledwyer
tumbledwyer approved these changes Dec 2, 2024
View reviewed changes
Copy link
Collaborator

@tumbledwyer tumbledwyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Zangetsu101 Zangetsu101 added ✅ Ready for merging and removed Bug 💅 Waiting For Review 🚀 Ready to deploy Deployment automation should pick this PR up and start auto-deploying it labels Dec 2, 2024
@Zangetsu101
Copy link
Collaborator

Got approval from JPF

@euanmillar euanmillar merged commit bc7d585 into develop Dec 2, 2024
55 of 59 checks passed
@euanmillar euanmillar deleted the heading-3-spacing branch December 2, 2024 15:50
github-actions bot pushed a commit that referenced this pull request Dec 2, 2024
Placeholder commit for PR #8111
1d58a54
@euanmillar euanmillar restored the heading-3-spacing branch December 3, 2024 14:13
euanmillar added a commit that referenced this pull request Dec 6, 2024
@euanmillar
Merge pull request #8124 from opencrvs/auto-pr-release-v1.6.1-8111-577
33e32ee 
🍒 Merge changes from PR #8111 to release-v1.6.1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tumbledwyer tumbledwyer tumbledwyer approved these changes

@jpye-finch jpye-finch Awaiting requested review from jpye-finch

Assignees
No one assigned
Labels
✅ Ready for merging
Projects
None yet
Milestone
v1.6.1
Development

Successfully merging this pull request may close these issues.
4 participants
@euanmillar @Zangetsu101 @ocrvs-bot @tumbledwyer