-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: upsertRegistrationIdentifier
gateway endpoint
#8034
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
rikukissa
reviewed
Nov 21, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So far so good!
naftis
changed the title
DRAFT upsertRegistrationIdentifier endpoint to gateway #7908
feat: upsertRegistrationIdentifier endpoint to gateway
Nov 28, 2024
naftis
added
the
🚀 Ready to deploy
Deployment automation should pick this PR up and start auto-deploying it
label
Nov 28, 2024
tahmidrahman-dsi
requested changes
Nov 28, 2024
Your environment is deployed to https://ocrvs-7908.opencrvs.dev |
rikukissa
removed
the
🚀 Ready to deploy
Deployment automation should pick this PR up and start auto-deploying it
label
Dec 4, 2024
tahmidrahman-dsi
requested changes
Dec 4, 2024
naftis
reviewed
Dec 9, 2024
naftis
approved these changes
Dec 9, 2024
naftis
added
the
🚀 Ready to deploy
Deployment automation should pick this PR up and start auto-deploying it
label
Dec 9, 2024
naftis
changed the title
feat: upsertRegistrationIdentifier endpoint to gateway
feat: Dec 9, 2024
upsertRegistrationIdentifier
gateway endpoint
tahmidrahman-dsi
approved these changes
Dec 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new endpoint to GraphQL gateway called
upsertRegistrationIdentifier
. This endpoint allows us to add a identifier like national ID to a child, or a temporary id like AID to track the record in a third party service. The identifier might not show anywhere in the UI unless it's added into the certificate.Discuss in #8174 whether this is the desired functionality.