Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: upsertRegistrationIdentifier gateway endpoint #8034

Merged
merged 23 commits into from
Dec 10, 2024

Conversation

Hyper3x
Copy link
Collaborator

@Hyper3x Hyper3x commented Nov 21, 2024

Adds a new endpoint to GraphQL gateway called upsertRegistrationIdentifier. This endpoint allows us to add a identifier like national ID to a child, or a temporary id like AID to track the record in a third party service. The identifier might not show anywhere in the UI unless it's added into the certificate.

Discuss in #8174 whether this is the desired functionality.

This comment has been minimized.

Copy link
Member

@rikukissa rikukissa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So far so good!

packages/gateway/src/features/registration/schema.graphql Outdated Show resolved Hide resolved
packages/workflow/src/records/state-transitions.ts Outdated Show resolved Hide resolved
@naftis naftis changed the title DRAFT upsertRegistrationIdentifier endpoint to gateway #7908 feat: upsertRegistrationIdentifier endpoint to gateway Nov 28, 2024
@naftis naftis added the 🚀 Ready to deploy Deployment automation should pick this PR up and start auto-deploying it label Nov 28, 2024
packages/gateway/src/graphql/schema.d.ts Outdated Show resolved Hide resolved
packages/workflow/src/records/handler/upsert.ts Outdated Show resolved Hide resolved
packages/workflow/src/records/handler/upsert.ts Outdated Show resolved Hide resolved
@ocrvs-bot
Copy link
Collaborator

Your environment is deployed to https://ocrvs-7908.opencrvs.dev

@rikukissa rikukissa removed the 🚀 Ready to deploy Deployment automation should pick this PR up and start auto-deploying it label Dec 4, 2024
packages/workflow/src/config/routes.ts Outdated Show resolved Hide resolved
packages/workflow/src/records/handler/utils.ts Outdated Show resolved Hide resolved
@Hyper3x Hyper3x self-assigned this Dec 5, 2024
@tahmidrahman-dsi tahmidrahman-dsi self-assigned this Dec 5, 2024
@naftis naftis self-requested a review December 9, 2024 13:00
@naftis naftis added the 🚀 Ready to deploy Deployment automation should pick this PR up and start auto-deploying it label Dec 9, 2024
@naftis naftis changed the title feat: upsertRegistrationIdentifier endpoint to gateway feat: upsertRegistrationIdentifier gateway endpoint Dec 9, 2024
@tahmidrahman-dsi tahmidrahman-dsi merged commit 7f3fccf into develop Dec 10, 2024
65 checks passed
@naftis naftis deleted the ocrvs-7908 branch December 10, 2024 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🚀 Ready to deploy Deployment automation should pick this PR up and start auto-deploying it
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants