Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Created confirmRegistration, rejectRegistration GraphQL-endpoints #7925

Merged
merged 14 commits into from
Nov 12, 2024

Conversation

Hyper3x
Copy link
Collaborator

@Hyper3x Hyper3x commented Nov 7, 2024

#7848

Created two new GraphQL endpoints confirmRegistration and rejectRegistration. Amended the confirm registration endpoint to be /records/{id}/confirm which was /confirm/registration.

@Hyper3x Hyper3x requested a review from naftis November 7, 2024 10:35
@Hyper3x Hyper3x self-assigned this Nov 7, 2024

This comment has been minimized.

@naftis naftis added 💅 Waiting For Review 🚀 Ready to deploy Deployment automation should pick this PR up and start auto-deploying it labels Nov 8, 2024
@ocrvs-bot
Copy link
Collaborator

Your environment is deployed to https://ocrvs-7848.opencrvs.dev

Hyper3x and others added 5 commits November 12, 2024 11:30
… event (#7882)

* Ticket 7849 implementation

* Added audience values to the event-specific token

* Removed unnecessary validations

* Minor changes

* Removed try catch block

* chore(changelog): clarify wording on what the token exchange means

* fix: add auth url to docker compose

* refactor: unify error handling

fixes a problem where the rejection error wasnt logged at all

---------

Co-authored-by: Pyry Rouvila <pyry@opencrvs.org>
Co-authored-by: naftis <pyry.rouvila@gmail.com>
@naftis naftis deployed to ocrvs-7848 November 12, 2024 13:20 — with GitHub Actions Active
@naftis naftis merged commit 2869fe8 into develop Nov 12, 2024
60 checks passed
@naftis naftis deleted the ocrvs-7848 branch November 12, 2024 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🚀 Ready to deploy Deployment automation should pick this PR up and start auto-deploying it 💅 Waiting For Review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants