Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: amend notification changes with scopes #7901

Merged
merged 2 commits into from
Nov 8, 2024

Conversation

Nil20
Copy link
Collaborator

@Nil20 Nil20 commented Nov 5, 2024

No description provided.

Copy link

github-actions bot commented Nov 5, 2024

Oops! Looks like you forgot to update the changelog. When updating CHANGELOG.md, please consider the following:

  • Changelog is read by country implementors who might not always be familiar with all technical details of OpenCRVS. Keep language high-level, user friendly and avoid technical references to internals.
  • Answer "What's new?", "Why was the change made?" and "Why should I care?" for each change.
  • If it's a breaking change, include a migration guide answering "What do I need to do to upgrade?".

Comment on lines 221 to 226
SCOPES.RECORD_DECLARE_BIRTH,
SCOPES.RECORD_DECLARE_DEATH,
SCOPES.RECORD_DECLARE_MARRIAGE,
SCOPES.RECORD_REGISTER,
SCOPES.RECORD_CERTIFY,
SCOPES.RECORD_SUBMIT_FOR_APPROVAL
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's take a closer look at the endpoints, for example this one is birthInProgressSMS so the following scopes makes sense in this ase:

  SCOPES.RECORD_DECLARE_BIRTH,
  SCOPES.RECORD_REGISTER,
  SCOPES.RECORD_PRINT_ISSUE_CERTIFIED_COPIES,
  SCOPES.RECORD_SUBMIT_FOR_APPROVAL

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also could take a look if this endpoint is actually being used or not? I'm a bit skeptical about that 😅

@Zangetsu101 Zangetsu101 merged commit b27226f into configurable-roles Nov 8, 2024
55 of 59 checks passed
@Zangetsu101 Zangetsu101 deleted the changes-notification branch November 8, 2024 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants