chore: amend gateway changes with scopes #7899
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oops! Looks like you forgot to update the changelog. When updating CHANGELOG.md, please consider the following:
|
Zangetsu101
requested changes
Nov 5, 2024
Nil20
force-pushed
the
changes-gateway-legacy-scopes
branch
2 times, most recently
from
06cd94c to
a91cbcd
Compare
Nil20
force-pushed
the
changes-gateway-legacy-scopes
branch
from
a91cbcd to
f640055
Compare
Zangetsu101
requested changes
Nov 8, 2024
| if ( | ||
| !hasScope(authHeader, 'sysadmin') && | ||
| !hasScope(authHeader, SCOPES.USER_READ) && |
There was a problem hiding this comment.
Suggested change
| !hasScope(authHeader, SCOPES.USER_READ) && | |
| !hasScope(authHeader, SCOPES.USER_UPDATE) && |
Zangetsu101
approved these changes
Nov 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.