(User roles) Fix merge issues #7881
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oops! Looks like you forgot to update the changelog. When updating CHANGELOG.md, please consider the following:
|
Nil20
reviewed
Nov 1, 2024
Comment on lines
+386
to
+393
| role: { | ||
| id: 'NATIONAL_REGISTRAR', | ||
| label: { | ||
| id: 'userRoles.nationalRegistrar', | ||
| defaultMessage: 'National Registrar', | ||
| description: '' | ||
| } | ||
| }, |
There was a problem hiding this comment.
Isn't this role supposed to be just the string NATIONAL_REGISTRAR?
There was a problem hiding this comment.
So I regenerated the gateway types and it came back with the label. So Typescript won't compile without it. Possibly need to discuss how we're using that file.
Zangetsu101
requested changes
Nov 1, 2024
There was a problem hiding this comment.
@tumbledwyer These were removed as part of this PR: #7697
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes breakages from the merge from develop