Simplifying gateways' return values #7863
Conversation
|
Oops! Looks like you forgot to update the changelog. When updating CHANGELOG.md, please consider the following:
|
|
Your environment is deployed to https://ocrvs-2520.opencrvs.dev |
| @@ -637,7 +596,7 @@ export const resolvers: GQLResolver = { | |||
| return taskEntry.resource.id | |||
| }, | |||
| async confirmRegistration(_, { id }, { headers: authHeader }) { | |||
| if (!inScope(authHeader, ['record.confirm-registration'])) { | |||
| if (!inScope(authHeader, ['record.confirm-registration'] as unknown as Scope[])) { | |||
There was a problem hiding this comment.
as unknown as Scope[] should be needed
packages/gateway/src/constants.ts
Outdated
| @@ -16,7 +16,7 @@ export const AVATAR_API = | |||
|
|
|||
| export const NATIVE_LANGUAGE = (() => { | |||
| const languages = env.LANGUAGES.split(',') | |||
| return languages.find((language) => language !== 'en') | |||
| return languages.find((language: string) => language !== 'en') | |||
There was a problem hiding this comment.
This is an unnecessary assertion: the compiler seems to already know it's a string.
There was a problem hiding this comment.
the parameter "language" was being implicitly given an any type which was causing an error when i ran the tests
|
@noah-brunate tests seem to be failing to unused variable but otherwise this looks like it's ready to go 👍 Great work |
| ) | ||
| } | ||
| return true |
There was a problem hiding this comment.
@noah-brunate removing this line here might break things as people could be expecting a boolean return value from the API.
This change is also the reason why you had to change the expectations in the test file. Let's bring this back please
Zangetsu101
added
🔧Waiting for fixes
and removed
💅 Waiting For Review
✅ Ready for merging
labels
Simplified the return values for the gateways' resolver functions.