Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libc/int: skip TestUpdateDevices* on i386 #4595

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

libc/int: skip TestUpdateDevices* on i386 #4595

wants to merge 1 commit into from

Conversation

kolyshkin
Copy link
Contributor

Fixes: #4594

@kolyshkin
libc/int: skip TestUpdateDevices* on i386
82544f7 
Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
@kolyshkin kolyshkin mentioned this pull request Jan 16, 2025
Open
@kolyshkin
Copy link
Contributor Author

Works as intended:

=== RUN   TestUpdateDevices
    update_test.go:20: flaky on i386, see https://github.com/opencontainers/runc/issues/4594
--- SKIP: TestUpdateDevices (0.00s)
=== RUN   TestUpdateDevicesSystemd
    update_test.go:20: flaky on i386, see https://github.com/opencontainers/runc/issues/4594
--- SKIP: TestUpdateDevicesSystemd (0.00s)
ok  	github.com/opencontainers/runc/libcontainer/integration	18.859s

@kolyshkin kolyshkin marked this pull request as ready for review January 16, 2025 21:10
@kolyshkin
Copy link
Contributor Author

Generally speaking, maybe we should just skip the entirety of libcontainer/integration as it's not really supposed to work, but since it works for now let's keep it as is.

@kolyshkin kolyshkin mentioned this pull request Jan 16, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rata rata Awaiting requested review from rata

@lifubang lifubang Awaiting requested review from lifubang

@thaJeztah thaJeztah Awaiting requested review from thaJeztah

@cyphar cyphar Awaiting requested review from cyphar

@AkihiroSuda AkihiroSuda Awaiting requested review from AkihiroSuda

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
area/ci easy-to-review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TestUpdateDevices fails on i386
1 participant
@kolyshkin