Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VERSION: release v1.2.4 #4581

Merged
merged 2 commits into from
Jan 7, 2025
Merged

Conversation

cyphar
Copy link
Member

@cyphar cyphar commented Jan 6, 2025

runc v1.2.4 -- "Христос се роди!"

This is the fourth patch release of the 1.2.z release branch of runc. It
includes a fix for a regression introduced in 1.2.0 related to the
default device list.

 * Re-add tun/tap devices to built-in allowed devices lists.

   In runc 1.2.0 we removed these devices from the default allow-list
   (which were added seemingly by accident early in Docker's history) as
   a precaution in order to try to reduce the attack surface of device
   inodes available to most containers (#3468). At the time we thought
   that the vast majority of users using tun/tap would already be
   specifying what devices they need (such as by using `--device` with
   Docker/Podman) as opposed to doing the `mknod` manually, and thus
   there would've been no user-visible change.

   Unfortunately, it seems that this regressed a noticeable number of
   users (and not all higher-level tools provide easy ways to specify
   devices to allow) and so this change needed to be reverted. Users
   that do not need these devices are recommended to explicitly disable
   them by adding deny rules in their container configuration. (#4555,
   #4556)

Thanks to all of the contributors who made this release possible:

 * Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
 * Aleksa Sarai <cyphar@cyphar.com>
 * Kir Kolyshkin <kolyshkin@gmail.com>
 * lifubang <lifubang@acmcoder.com>

Signed-off-by: Aleksa Sarai <cyphar@cyphar.com>

@cyphar cyphar added this to the 1.2.4 milestone Jan 6, 2025
cyphar added 2 commits January 7, 2025 10:20
Signed-off-by: Aleksa Sarai <cyphar@cyphar.com>
Signed-off-by: Aleksa Sarai <cyphar@cyphar.com>
Copy link
Contributor

@kolyshkin kolyshkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@cyphar cyphar merged commit 2a42461 into opencontainers:release-1.2 Jan 7, 2025
40 checks passed
@cyphar cyphar deleted the release-1.2.4 branch January 7, 2025 06:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants