-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update syscall to start loong64 support #3765
base: main
Are you sure you want to change the base?
Conversation
// +build linux | ||
// +build arm64 amd64 mips mipsle mips64 mips64le ppc ppc64 ppc64le riscv64 s390x | ||
// +build arm64 amd64 loong64 mips mipsle mips64 mips64le ppc ppc64 ppc64le riscv64 s390x | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
seccomp needs to be updated too
runc/libcontainer/seccomp/config.go
Line 74 in a2f27f0
"SCMP_ARCH_RISCV64": "riscv64", |
const uint32_t C_AUDIT_ARCH_RISCV64 = AUDIT_ARCH_RISCV64; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
...and libseccomp-golang needs to be updated as well (see seccomp/libseccomp-golang#106)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
...and libseccomp-golang needs to be updated as well (see seccomp/libseccomp-golang#106)
Sorry, I didn't know that you had submitted a PR before submitting the PR (seccomp/libseccomp-golang#107), but there are some differences in the submitted code, please review
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
seccomp needs to be updated too
runc/libcontainer/seccomp/config.go
Line 74 in a2f27f0
"SCMP_ARCH_RISCV64": "riscv64",
const uint32_t C_AUDIT_ARCH_RISCV64 = AUDIT_ARCH_RISCV64;
I have updated it, please check
96783d9
to
7930666
Compare
Let's wait until runc dependencies have loong64 supported. That includes:
Once all that is ready and released, we can add the support. Doing it earlier doesn't make much practical sense. |
@kolyshkin |
runc does not support loongarch64 yet. opencontainers/runc#3765
|
The LoongArch architecture (LoongArch) is an Instruction Set Architecture (ISA) that has a RISC style.
Documentations:
ISA:
https://loongson.github.io/LoongArch-Documentation/LoongArch-Vol1-EN.html
ABI:
https://loongson.github.io/LoongArch-Documentation/LoongArch-ELF-ABI-EN.html
More docs can be found at:
https://loongson.github.io/LoongArch-Documentation/README-EN.html