Skip to content

Commit

Permalink
tests/int: add hooks argv[0] test
Browse files Browse the repository at this point in the history
Looking into old opened runc issues, I noticed #1663 is there without
any resolution, and wrote this simple test checking if we mangle hook's
argv[0] in any way.

Apparently we're good, but the test actually makes sense to have.

Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
  • Loading branch information
kolyshkin committed Jan 16, 2025
1 parent 610aa88 commit cac62a7
Showing 1 changed file with 17 additions and 0 deletions.
17 changes: 17 additions & 0 deletions tests/integration/hooks.bats
Original file line number Diff line number Diff line change
Expand Up @@ -63,3 +63,20 @@ function teardown() {
runc run ct1
[ "$status" -eq 0 ]
}

# https://github.com/opencontainers/runc/issues/1663
@test "runc run [hook's argv is preserved]" {
# Check that argv[0] and argv[1] passed to the hook's binary
# exactly as set in config.json.
update_config '.hooks |= {"startContainer": [{"path": "/bin/busybox", "args": ["cat", "/nosuchfile"]}]}'
runc run ct1
[ "$status" -ne 0 ]
[[ "$output" == *"cat: can't open"*"/nosuchfile"* ]]

# Busybox also accepts commands where argv[0] is "busybox",
# and argv[1] is applet name. Test this as well.
update_config '.hooks |= {"startContainer": [{"path": "/bin/busybox", "args": ["busybox", "cat", "/nosuchfile"]}]}'
runc run ct1
[ "$status" -ne 0 ]
[[ "$output" == *"cat: can't open"*"/nosuchfile"* ]]
}

0 comments on commit cac62a7

Please sign in to comment.