Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move imports in osc plugins from top level to individual functions to reduce osc load times #3168

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dmach
Copy link
Contributor

@dmach dmach commented Sep 30, 2024

No description provided.

@dmach dmach force-pushed the move-imports-to-osc-plugins branch from dbb38a6 to 653b55d Compare September 30, 2024 14:04
@dirkmueller
Copy link
Member

This is kinda ugly. can we maybe split the functions that need osc into a separate module that is then only loaded on demand? e.g. just one function-embedded load rather than all of them moved (which still then allows to pyflake check for missing imports imho, which is a nice property to keep).

@dmach
Copy link
Contributor Author

dmach commented Oct 1, 2024

@dirkmueller good point, that sounds like a sane approach.
Unfortunately when I tried that, it improves some things while making others worse.
That new module would have to be imported on too many places anyway so it only adds more complexity to the code.
Maybe if you have an exact idea on how to do it, could you share it with me?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants