Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for openMINDS v4.0 #32

Merged
merged 6 commits into from
Nov 15, 2024
Merged

Add support for openMINDS v4.0 #32

merged 6 commits into from
Nov 15, 2024

Conversation

ehennestad
Copy link
Collaborator

  • Add v4.0 of openMINDS
  • Change generation of MATLAB class names. Will always be defined on long form (including group name if present) in code, i.e openminds.core.actors.Person
  • Remove a lot of unnecessary mixed type classes
  • Fix bug preventing generation of ParameterSetting for v1.0
  • Pipeline supports namespace change

Copy link

github-actions bot commented Nov 13, 2024

Test Results

464 tests  +1   464 ✅ +1   59s ⏱️ +5s
  6 suites ±0     0 💤 ±0 
  1 files   ±0     0 ❌ ±0 

Results for commit 393b865. ± Comparison against base commit 6e17260.

♻️ This comment has been updated with latest results.

Copy link

codecov bot commented Nov 13, 2024

Codecov Report

Attention: Patch coverage is 33.33333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 37.05%. Comparing base (6e17260) to head (393b865).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...ode/internal/+openminds/+constant/LATEST_VERSION.m 0.00% 1 Missing ⚠️
...rnal/+openminds/+internal/+utility/VersionNumber.m 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #32      +/-   ##
==========================================
+ Coverage   36.99%   37.05%   +0.06%     
==========================================
  Files         323      323              
  Lines        3117     3117              
==========================================
+ Hits         1153     1155       +2     
+ Misses       1964     1962       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ehennestad ehennestad changed the title Build triggered by manual update to pipeline Add support for openMINDS v4.0 Nov 15, 2024
@ehennestad ehennestad merged commit 0f8aeb5 into main Nov 15, 2024
5 checks passed
@ehennestad ehennestad deleted the staging branch November 26, 2024 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant