Skip to content

Commit

Permalink
profiles: align type of index into string table (#557)
Browse files Browse the repository at this point in the history
With `Mapping.filename`, `Function.name`, `Label.key` and others the type of the index into the string table is always of type `int64`.
For consistency align the type of `Location.type_index`, which is also an index into the string table, to `int64`.

Co-authored-by: Tigran Najaryan <4194920+tigrannajaryan@users.noreply.github.com>
  • Loading branch information
florianl and tigrannajaryan authored Aug 13, 2024
1 parent 35c9780 commit 14afbd4
Showing 1 changed file with 1 addition and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -355,7 +355,7 @@ message Location {
bool is_folded = 5;

// Type of frame (e.g. kernel, native, python, hotspot, php). Index into string table.
uint32 type_index = 6;
int64 type_index = 6;

// References to attributes in Profile.attribute_table. [optional]
repeated uint64 attributes = 7;
Expand Down

0 comments on commit 14afbd4

Please sign in to comment.