[CHORE] adding ebpf collector #833
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* POC CRD generation with template Signed-off-by: Matej Gera <matejgera@gmail.com> * Improve values structure; add target allocator Signed-off-by: Matej Gera <matejgera@gmail.com> * More improvements to target allocator; add service account and cluster role for target allocator Signed-off-by: Matej Gera <matejgera@gmail.com> * More formatting; add more docs Signed-off-by: Matej Gera <matejgera@gmail.com> * Bump chart version Signed-off-by: Matej Gera <matejgera@gmail.com> --------- Signed-off-by: Matej Gera <matejgera@gmail.com>
* Fix condition for generating SA / CR Signed-off-by: Matej Gera <matejgera@gmail.com> * Fix extra env indentation Signed-off-by: Matej Gera <matejgera@gmail.com> * Bump chart Signed-off-by: Matej Gera <matejgera@gmail.com> --------- Signed-off-by: Matej Gera <matejgera@gmail.com>
* Add MySQL POC Signed-off-by: Matej Gera <matejgera@gmail.com> * Enhance preset to allow specifying multiple MySQL instances Signed-off-by: Matej Gera <matejgera@gmail.com> * Extend values to include MySQL logs preset config Signed-off-by: Matej Gera <matejgera@gmail.com> * Ensure cluste role is generate if metrics enabled Signed-off-by: Matej Gera <matejgera@gmail.com> * Generate examples Signed-off-by: Matej Gera <matejgera@gmail.com> * Bump Chart version Signed-off-by: Matej Gera <matejgera@gmail.com> * Regenerate examples Signed-off-by: Matej Gera <matejgera@gmail.com> * More docs Signed-off-by: Matej Gera <matejgera@gmail.com> --------- Signed-off-by: Matej Gera <matejgera@gmail.com>
nicolastakashi
requested review from
dmitryax,
TylerHelmuth and
povilasv
as code owners
|
cc @atoulme |
|
Nice! Thanks for this work. |
|
@nicolastakashi what would you think of making this a new top level chart? @TylerHelmuth is there a process to add a new chart? |
|
@atoulme new charts should be proposed via an Issue. |
|
@nicolastakashi I do not have the context necessary to review this PR. Can you create an issue (or can we move the issue linked to this PR) to discuss what problem this PR solves? |
|
I suggest making it another helm chart. Later, if we want it to be installable along with the collector, it can be set as a subchart. Or, just provide instructions on how to install it with the collector |
|
made an issue for this #835 |
Closed
|
This PR was marked stale due to lack of activity. It will be closed in 14 days. |
Signed-off-by: Nicolas Takashi <nicolas.takashi@coralogix.com>
nicolastakashi
force-pushed
the
chore/ebpf-collector
branch
from
957d153 to
f8458c2
Compare
|
Going to open another PR, cause I was struggling with conflicts |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As proposed on this open-telemetry/opentelemetry-network#186, I'm adding the eBPF collector as part of the collector helm chart.