Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add extraManifests to opentelemetry-collector helm chart #1484

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

SBejga
Copy link

@SBejga SBejga commented Jan 9, 2025

This PR is adding the possibility to specify extra manifests to deploy with the opentelemetry-collector.

e.g. if you are managing secrets with external secrets operator or onepassword-operator you need to specify an additional manifest, that will create a secret for you, that you can use with the opentelemetry-collector.

Example using onepassword-operator

extraManifests:
- apiVersion: onepassword.com/v1
  kind: OnePasswordItem
  metadata:
    name: example-onepassword-secret
  spec:
    itemPath: vaults/Examples/items/example

I have seen and used this in several projects by using a helm parameter extraManifests and want to add this to the opentelemetry-collector helm chart.

@SBejga SBejga requested review from dmitryax, TylerHelmuth, povilasv and a team as code owners January 9, 2025 12:45
Copy link

linux-foundation-easycla bot commented Jan 9, 2025

CLA Signed


The committers listed above are authorized under a signed CLA.

@TylerHelmuth
Copy link
Member

Fixes #1361. @open-telemetry/helm-approvers I'd like your opinion before moving forward with this idea.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants