Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(opentelemetry-operator): remove default resource values #1457

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion charts/opentelemetry-operator/Chart.yaml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
apiVersion: v2
name: opentelemetry-operator
version: 0.77.0
version: 0.78.0
description: OpenTelemetry Operator Helm chart for Kubernetes
type: application
home: https://opentelemetry.io/
Expand Down
24 changes: 24 additions & 0 deletions charts/opentelemetry-operator/UPGRADING.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,29 @@
# Upgrade guidelines

## 0.77.0 to 0.78.0

Prior to 0.78.0, this chart included resource requests and limits for the OpenTelemetry Operator manager pod. These values were set to `100m` and `128Mi` respectively. In 0.78.0, these values have been removed from the chart. If you were relying on these values, you can set them in your `values.yaml` file. For example:

```yaml
manager:
resources:
limits:
cpu: 100m
memory: 128Mi
requests:
cpu: 100m
memory: 64Mi

kubeRBACProxy:
resources:
limits:
cpu: 500m
memory: 128Mi
requests:
cpu: 5m
memory: 64Mi
```
## 0.74.0 to 0.74.1
Prior to 0.72.1, feature gates could be enabled via the `manager.featureGates` property. As feature gates may require extra configuration to work properly, e.g. deploying extra permissions on the ClusterRole, the chart has been updated to make use of the `manager.featureGatesMap` property which allows the chart to smartly configure feature gates. If the `manager.featureGatesMap` property is set, the old `manager.featureGates` property will be ignored.
Expand Down
36 changes: 20 additions & 16 deletions charts/opentelemetry-operator/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -90,15 +90,18 @@
metricsPort: 8080
webhookPort: 9443
healthzPort: 8081
resources:
limits:
cpu: 100m
memory: 128Mi
# ephemeral-storage: 50Mi
requests:
cpu: 100m
memory: 64Mi
# ephemeral-storage: 50Mi

resources: {}
# resources:
# limits:
# cpu: 100m
# memory: 128Mi
# ephemeral-storage: 50Mi
# requests:
# cpu: 100m
# memory: 64Mi
# ephemeral-storage: 50Mi

Check failure on line 104 in charts/opentelemetry-operator/values.yaml

View workflow job for this annotation

GitHub Actions / lint-test

104:1 [trailing-spaces] trailing spaces
## Adds additional environment variables
## e.g ENV_VAR: env_value
env:
Expand Down Expand Up @@ -208,13 +211,14 @@
tag: v0.18.1
ports:
proxyPort: 8443
resources:
limits:
cpu: 500m
memory: 128Mi
requests:
cpu: 5m
memory: 64Mi
resources: {}
# resources:
# limits:
# cpu: 500m
# memory: 128Mi
# requests:
# cpu: 5m
# memory: 64Mi

## List of additional cli arguments to configure the kube-rbac-proxy
## for example: --tls-cipher-suites, --tls-min-version, etc.
Expand Down
Loading