Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change k8sobjects typo in values.yaml comment #1451

Merged
merged 9 commits into from
Dec 10, 2024
Merged

Change k8sobjects typo in values.yaml comment #1451

merged 9 commits into from
Dec 10, 2024

Conversation

timofey-drozhzhin
Copy link
Contributor

This fixes #1450

@linux-foundation-easycla Linux Foundation: EasyCLA
Copy link

linux-foundation-easycla bot commented Dec 6, 2024 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

@timofey-drozhzhin timofey-drozhzhin mentioned this pull request Dec 6, 2024
Closed
@povilasv
Copy link
Contributor

povilasv commented Dec 6, 2024

@timofey-drozhzhin please sign the CLA and follow:

  1. https://github.com/open-telemetry/opentelemetry-helm-charts/blob/main/CONTRIBUTING.md#versioning
  2. https://github.com/open-telemetry/opentelemetry-helm-charts/blob/main/CONTRIBUTING.md#examples

@timofey-drozhzhin
Copy link
Contributor Author

timofey-drozhzhin commented Dec 6, 2024 •
edited
Loading

CLA - Signed

  1. Versioning changed
  2. Examples updated

@timofey-drozhzhin
Copy link
Contributor Author

timofey-drozhzhin commented Dec 7, 2024 •
edited
Loading

Bumped versions again as it seems there was a version conflict with another commit.

@TylerHelmuth TylerHelmuth merged commit 2eff305 into open-telemetry:main Dec 10, 2024
4 checks passed
jtyr pushed a commit to jtyr/opentelemetry-helm-charts that referenced this pull request Dec 23, 2024
@timofey-drozhzhin @TylerHelmuth @jtyr
Change k8sobjects typo in values.yaml comment (open-telemetry#1451)
56fc9b4 
* fix: correct typo in comments for k8sobjects receiver in values.yaml

* fix: correct typo in comments for k8sobjects receiver in opentelemetry-kube-stack values.yaml

* chore: bump version to 0.110.5 in opentelemetry-collector Chart.yaml

* chore: bump version to 0.3.5 in opentelemetry-kube-stack Chart.yaml

* Update examples in opentelemetry-collector-0.110.5

* Update examples in opentelemetry-kube-stack-0.3.5

* opentelemetry-collector: bump version to 0.110.6 and update examples

* opentelemetry-kube-stack: bump version to 0.3.6 and update examples

---------

Co-authored-by: Tyler Helmuth <12352919+TylerHelmuth@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TylerHelmuth TylerHelmuth TylerHelmuth approved these changes

@jaronoff97 jaronoff97 jaronoff97 approved these changes

@dmitryax dmitryax Awaiting requested review from dmitryax dmitryax is a code owner

@povilasv povilasv Awaiting requested review from povilasv povilasv is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Change type in values.yaml comment
4 participants
@timofey-drozhzhin @povilasv @jaronoff97 @TylerHelmuth