Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only run link check on main branch merge #6563

Merged
merged 2 commits into from
Jan 6, 2025

Conversation

MrAlias
Copy link
Contributor

@MrAlias MrAlias commented Jan 6, 2025

Copies open-telemetry/opentelemetry-go#6098

Right now we are doubling our link checks for PRs against branches hosted on the main repository. This is likely not helping our 429 issue with link checking.

@MrAlias MrAlias added the Skip Changelog Allow PR to succeed without requiring an addition to the CHANGELOG label Jan 6, 2025
@MrAlias MrAlias requested a review from a team as a code owner January 6, 2025 16:04
Copy link

codecov bot commented Jan 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.5%. Comparing base (4caabdb) to head (cf6c755).

Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #6563   +/-   ##
=====================================
  Coverage   68.5%   68.5%           
=====================================
  Files        200     200           
  Lines      16781   16781           
=====================================
+ Hits       11500   11503    +3     
+ Misses      4935    4933    -2     
+ Partials     346     345    -1     

see 1 file with indirect coverage changes

@MrAlias
Copy link
Contributor Author

MrAlias commented Jan 6, 2025

Trivial, merging early.

@MrAlias MrAlias merged commit 2c0580a into open-telemetry:main Jan 6, 2025
26 checks passed
@MrAlias MrAlias deleted the link-main-branch branch January 6, 2025 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip Changelog Allow PR to succeed without requiring an addition to the CHANGELOG
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants