Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support output value in AttributeSetter #6543

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Apply suggestions to changelog

9309250
Select commit
Loading
Failed to load commit list.
Open

Support output value in AttributeSetter #6543

Apply suggestions to changelog
9309250
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jan 10, 2025 in 1s

68.5% (+0.0%) compared to 00786cc

View this Pull Request on Codecov

68.5% (+0.0%) compared to 00786cc

Details

Codecov Report

Attention: Patch coverage is 88.88889% with 3 lines in your changes missing coverage. Please review.

Project coverage is 68.5%. Comparing base (00786cc) to head (9309250).
Report is 45 commits behind head on main.

Files with missing lines Patch % Lines
...github.com/aws/aws-sdk-go-v2/otelaws/attributes.go 66.6% 1 Missing ⚠️
...hub.com/aws/aws-sdk-go-v2/otelaws/snsattributes.go 50.0% 1 Missing ⚠️
...hub.com/aws/aws-sdk-go-v2/otelaws/sqsattributes.go 50.0% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #6543   +/-   ##
=====================================
  Coverage   68.5%   68.5%           
=====================================
  Files        200     200           
  Lines      16768   16800   +32     
=====================================
+ Hits       11490   11519   +29     
- Misses      4933    4937    +4     
+ Partials     345     344    -1     
Files with missing lines Coverage Δ
...tation/github.com/aws/aws-sdk-go-v2/otelaws/aws.go 95.8% <100.0%> (+0.1%) ⬆️
...ion/github.com/aws/aws-sdk-go-v2/otelaws/config.go 100.0% <100.0%> (ø)
...om/aws/aws-sdk-go-v2/otelaws/dynamodbattributes.go 100.0% <100.0%> (ø)
...github.com/aws/aws-sdk-go-v2/otelaws/attributes.go 89.4% <66.6%> (+7.1%) ⬆️
...hub.com/aws/aws-sdk-go-v2/otelaws/snsattributes.go 81.4% <50.0%> (-6.6%) ⬇️
...hub.com/aws/aws-sdk-go-v2/otelaws/sqsattributes.go 94.4% <50.0%> (-5.6%) ⬇️

... and 3 files with indirect coverage changes