Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal: Go Compile Time Instrumentation SIG #2490

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

ralf0131
Copy link

This is a proposal to establish the Go compile time instrumentation SIG. The background has been discussed in #1961. A consensus has been reached among GC/TC members, Go maintainers and multiple interested vendors.
We believe that the Go Compile Time Instrumentation SIG ensures that Go applications benefit from standardized, vendor-neutral, high-quality observability solutions that are both robust and easy to implement. Having one single, standard tool removes decision points from prospective developers, which makes the path to observability shorter & easier.

Copy link

linux-foundation-easycla bot commented Dec 14, 2024

CLA Signed

The committers listed above are authorized under a signed CLA.

@123liuziming
Copy link

I approve!

1 similar comment
@NameHaibinZhang
Copy link

I approve!

@trask
Copy link
Member

trask commented Jan 8, 2025

@123liuziming @NameHaibinZhang @y1yang0 can you please review the changes and approve it if it looks good to you (instead of only leaving a comment)? thanks

Copy link

@123liuziming 123liuziming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@123liuziming
Copy link

@123liuziming @NameHaibinZhang @y1yang0 can you please review the changes and approve it if it looks good to you (instead of only leaving a comment)? thanks

Sorry, I do not realize that I have the access to approve, thanks!

Copy link

@Cirilla-zmh Cirilla-zmh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@jpkrohling jpkrohling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

my comment/suggestion isn't blocking, I'm happy to sponsor this SIG!

projects/go-compile-instrumentation.md Outdated Show resolved Hide resolved
projects/go-compile-instrumentation.md Show resolved Hide resolved
projects/go-compile-instrumentation.md Outdated Show resolved Hide resolved
projects/go-compile-instrumentation.md Outdated Show resolved Hide resolved
projects/go-compile-instrumentation.md Show resolved Hide resolved
@danielgblanco
Copy link
Contributor

Should this project proposal include mentions of the two donation proposals that will be considered as part of this work? The one from Alibaba in #2344 and Datadog in #2497

I think it's awesome that we can get the best learnings from each and provide the community with a unified approach. Would love to see it reflected here.

@ralf0131
Copy link
Author

Should this project proposal include mentions of the two donation proposals that will be considered as part of this work? The one from Alibaba in #2344 and Datadog in #2497

I think it's awesome that we can get the best learnings from each and provide the community with a unified approach. Would love to see it reflected here.

How about adding the following content to the end of the proposal

Reference

The project is a joint effort of donation proposal coming from Alibaba and Datadog. The proposals are listed as follows:

@danielgblanco
Copy link
Contributor

I think that'd be great @ralf0131

@ralf0131
Copy link
Author

I think that'd be great @ralf0131

All the suggestion are applied.
Unfortunately the CI fails and it looks like there is a dead link found in project/event-api.md file which is beyond the scope this proposal. Any ideas how to fix it?

@pdelewski
Copy link
Member

Should this project proposal include mentions of the two donation proposals that will be considered as part of this work? The one from Alibaba in #2344 and Datadog in #2497
I think it's awesome that we can get the best learnings from each and provide the community with a unified approach. Would love to see it reflected here.

How about adding the following content to the end of the proposal

Reference

The project is a joint effort of donation proposal coming from Alibaba and Datadog. The proposals are listed as follows:

I think, we could also mention that goal is also to replace https://github.com/open-telemetry/opentelemetry-go-contrib/tree/main/instrgen

@ralf0131
Copy link
Author

I think, we could also mention that goal is also to replace https://github.com/open-telemetry/opentelemetry-go-contrib/tree/main/instrgen

Sure. How about this?

The project is a joint effort of donation proposal coming from Alibaba and Datadog to replace Instrgen. The proposals are listed as follows:

@trask
Copy link
Member

trask commented Jan 10, 2025

Unfortunately the CI fails and it looks like there is a dead link found in project/event-api.md file which is beyond the scope this proposal. Any ideas how to fix it?

fixed in #2503 and merged latest into your branch, should be fixed now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/project-proposal Submitting a filled out project template
Projects
None yet
Development

Successfully merging this pull request may close these issues.