Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add filtering for usernames on user-contributions #60

Merged
merged 1 commit into from
Oct 26, 2023

Conversation

jpmcb
Copy link
Member

@jpmcb jpmcb commented Oct 26, 2023

Description

Followup to #58

Adds filtering for users on the user-contributions command

❯ ./build/pizza insights user-contributions \
    https://github.com/open-sauced/api \
    https://github.com/open-sauced/app \
    --users jpmcb,brandonroberts

https://github.com/open-sauced/api
User           Total      Commits    PRs Created
brandonroberts 4          0          4
jpmcb          5          0          5

https://github.com/open-sauced/app
User           Total      Commits    PRs Created
brandonroberts 368        334        34
jpmcb          6          5          1

What type of PR is this? (check all applicable)

  • 🍕 Feature
  • 🐛 Bug Fix
  • 📝 Documentation Update
  • 🎨 Style
  • 🧑‍💻 Code Refactor
  • 🔥 Performance Improvements
  • ✅ Test
  • 🤖 Build
  • 🔁 CI
  • 📦 Chore (Release)
  • ⏩ Revert

Related Tickets & Documents

Closes #57 - decided against adding a whole extra command since this actually gets us pretty close by just adding a filter. Can continue to iterate based on feedback.

Mobile & Desktop Screenshots/Recordings

Added tests?

  • 👍 yes
  • 🙅 no, because they aren't needed
  • 🙋 no, because I need help

Added to documentation?

  • 📜 README.md
  • 📓 docs.opensauced.pizza
  • 🍕 dev.to/opensauced
  • 📕 storybook
  • 🙅 no documentation needed

[optional] Are there any post-deployment tasks we need to perform?

[optional] What gif best describes this PR or how it makes you feel?

Signed-off-by: John McBride <john@opensauced.pizza>
@jpmcb jpmcb force-pushed the filter-for-usernames branch from 1351043 to d10c1ef Compare October 26, 2023 20:04
@jpmcb jpmcb marked this pull request as ready for review October 26, 2023 20:04
@jpmcb jpmcb requested a review from a team October 26, 2023 20:04
Copy link
Contributor

@brandonroberts brandonroberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🍕

@jpmcb jpmcb merged commit 516b110 into open-sauced:beta Oct 26, 2023
6 checks passed
@jpmcb jpmcb deleted the filter-for-usernames branch October 26, 2023 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: implement pizza insights users
2 participants