Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: docsify to docusaurus #222

Merged
merged 61 commits into from
Jun 12, 2024
Merged

feat: docsify to docusaurus #222

merged 61 commits into from
Jun 12, 2024

Conversation

BekahHW
Copy link
Member

@BekahHW BekahHW commented Jun 11, 2024

Description

Moved all the content over to docusaurus to prep for making it a subdirectory.

Needs done

  • Change the Tips to Admonitions
  • Double check that all files were moved over
  • Remove the "edit this page footer"

Related Tickets & Documents

closes #217

Mobile & Desktop Screenshots/Recordings

image

Steps to QA

https://deploy-preview-222--sauced-intro.netlify.app/

Tier (staff will fill in)

  • Tier 1
  • Tier 2
  • Tier 3
  • Tier 4

[optional] What gif best describes this PR or how it makes you feel?

@BekahHW BekahHW requested a review from a team as a code owner June 11, 2024 00:39
Copy link

netlify bot commented Jun 11, 2024

Deploy Preview for sauced-intro ready!

Name Link
🔨 Latest commit 3e089e7
🔍 Latest deploy log https://app.netlify.com/sites/sauced-intro/deploys/666a02aca96c86000813c4a1
😎 Deploy Preview https://deploy-preview-222--sauced-intro.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@adiati98 adiati98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@BekahHW, this is great! Everything works as it should! 🎉

I left some reviews here.

There's also one thing. The blog link on the navbar leads to the OpenSauced blog and the other on footer leads to DEV. Is this on purpose?

If you need me to, I can get through the checklist and fix them. Just let me know. Thanks!

sidebars.js Outdated Show resolved Hide resolved
docs/intro-to-oss/README 2.md Outdated Show resolved Hide resolved
docusaurus.config.js Outdated Show resolved Hide resolved
@open-sauced open-sauced deleted a comment from adiati98 Jun 11, 2024
@BekahHW
Copy link
Member Author

BekahHW commented Jun 11, 2024

@adiati98 I think everything is there an where it needs to be. Two things that could be done:

  1. We need to decide what to do with the translations. It looks like both of those discussions have support. So we might just need to provide them with instructions. I did remove the section on translations in here, so we should probably add info in the main readme.
  2. The key words are just the titles with Open Source and Open Source community. Ideally, we'd be more specific with each page.

Ideally, we get this merged in sooner rather than later. So we might need

@adiati98
Copy link
Member

@adiati98 I think everything is there an where it needs to be. Two things that could be done:

  1. We need to decide what to do with the translations. It looks like both of those discussions have support. So we might just need to provide them with instructions. I did remove the section on translations in here, so we should probably add info in the main readme.
  2. The key words are just the titles with Open Source and Open Source community. Ideally, we'd be more specific with each page.

Ideally, we get this merged in sooner rather than later. So we might need

Hey @BekahHW,

I'm no longer on my computer. So I'll check these tomorrow. 🙂

Quick responding to you here:

  1. Yes, I believe both translations have support. I don't think we need to add any info in the main README. We do, however, need to update the translation guidelines (issue Feature: Update translations guidelines #212) to completely hold all information about community translations, including the instructions.
  2. We can create another issue for the keywords and work on it later if we want this to be merged fast. That way, we can think through of suitable keywords to put in each page.

Also, your comment is cut off. Is there any continuation there? 😅

Copy link
Member

@adiati98 adiati98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

woohoo gif

Copy link
Member

@nickytonline nickytonline left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Loaded the site and everything seems to be working.

@BekahHW BekahHW merged commit c042f88 into main Jun 12, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: transfer course to docusaurus
3 participants