Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add @mohanamisra as a contributor #554

Merged
merged 3 commits into from
Nov 4, 2024

Conversation

mohanamisra
Copy link
Contributor

@mohanamisra mohanamisra commented Nov 1, 2024

Description

Adding user @mohanamisra (yours truly) as a contributor to this repository, as required in the Intro to Open Source course by OpenSauced.

What type of PR is this? (check all applicable)

  • 🤝 Add a contributor
  • 📝 Documentation Update

Related Issues

Closes #553

Contributors Checklist

I've read through the Getting Started section

  • ✅ Yes
  • ❌ Not yet

Have you run npm run contributors:generate to generate your profile and the badge on the README?

  • ✅ Yes
  • ❌ No

Added to documentation?

  • 📜 README.md
  • 🙅 no documentation needed

Screenshot (Required for PR Review)

image

[optional] What GIF best describes this PR or how it makes you feel?

68747470733a2f2f73332e616d617a6f6e6177732e636f6d2f776174747061642d6d656469612d736572766963652f53746f7279496d6167652f386568486d71734a3135344d58773d3d2d3839373430373335352e313631353131313165363838653639643535343336363133343637372e676966

@mohanamisra mohanamisra requested a review from a team as a code owner November 1, 2024 17:21
Copy link

github-actions bot commented Nov 1, 2024

Congratulations on completing the How to Contribute to Open Source chapter of the Intro to Open Source Course with your contribution to this repository, @mohanamisra! You're almost to the end of the course. Create a highlight of your contribution to our guestbook using the instructions in the next chapter and share it with us!

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Compliance Checks Passed!

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congrats on making your first Pull Request and thanks for taking the time to improve Open Sauced! ❤️! 🎉🍕
Say hello by joining the conversation in our Discord

@BekahHW
Copy link
Member

BekahHW commented Nov 1, 2024

Hey @mohanamisra there's a slight change you need in the issue Closes Issue #553, but you need to remove the word "issue" because it breaks the key word closes from the issue number. So you'll need to edit that part of your PR description to closes #553.

@mohanamisra
Copy link
Contributor Author

Hey @mohanamisra there's a slight change you need in the issue Closes Issue #553, but you need to remove the word "issue" because it breaks the key word closes from the issue number. So you'll need to edit that part of your PR description to closes #553.

Made the required change. Awaiting review!

Copy link
Member

@adiati98 adiati98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @mohanamisra,
Thank you for your contribution! ✨

However, there are new files that we don't want to have here. Please remove them.

Let us know when it's fixed and ready for a review.
Thank you. 🙂

.idea/.gitignore Outdated Show resolved Hide resolved
.idea/guestbook.iml Outdated Show resolved Hide resolved
.idea/modules.xml Outdated Show resolved Hide resolved
.idea/vcs.xml Outdated Show resolved Hide resolved
@mohanamisra
Copy link
Contributor Author

However, there are new files that we don't want to have here. Please remove them.

Let us know when it's fixed and ready for a review. Thank you. 🙂

I apologise for that !
Removed the extra files as requested.

Copy link
Member

@adiati98 adiati98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done and thank you for your contribution, @mohanamisra! ✨

If you haven't, you can join our Community.
Also, check out our pizza-verse repo if you want to contribute further! 🍕🍴

well done GIF

@adiati98 adiati98 requested a review from BekahHW November 4, 2024 16:48
@adiati98 adiati98 merged commit d05e560 into open-sauced:main Nov 4, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: Add @mohanamisra as a contributor
3 participants