Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add @sunggeorge as a contributor #318

Merged
merged 1 commit into from
May 17, 2024

Conversation

sunggeorge
Copy link
Contributor

@sunggeorge sunggeorge commented May 17, 2024

Description

Added @sunggeorge as contributor in README.md

What type of PR is this? (check all applicable)

  • 🤝 Add a contributor
  • 📝 Documentation Update

Related Issues

Closes #317

Contributors Checklist

I've read through the Getting Started section.

  • ✅ Yes
  • ❌ Not yet

Have you run npm run contributors:generate to generate your profile and the badge on the README?

  • ✅ Yes
  • ❌ No

Added to documentation?

  • 📜 README.md
  • 🙅 no documentation needed

Screenshot (Required for PR Review)

image

[optional] What GIF best describes this PR or how it makes you feel?

@sunggeorge sunggeorge requested a review from a team May 17, 2024 07:42
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Compliance Checks Passed!

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congrats on making your first Pull Request and thanks for taking the time to improve Open Sauced! ❤️! 🎉🍕
Say hello by joining the conversation in our Discord

@sunggeorge
Copy link
Contributor Author

sunggeorge commented May 17, 2024

Could you please pvoide some hint for failed item "Intro Course Contributor Action / intro_course_contributor (pull_request_target)" ? I compared with oher successful PR but still have no idea. thanks

Copy link
Member

@adiati98 adiati98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done and thank you for your contribution, @sunggeorge! ✨

As for the failed check, you don't have to worry about this one.
We're fixing it internally. 🙂

If you haven't, you can join our community Discord.
Also, check out our pizza-verse repo if you want to contribute further! 🍕🍴

git merge GIF

@adiati98 adiati98 merged commit bd950e7 into open-sauced:main May 17, 2024
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: Add @sunggeorge as a contributor
2 participants