-
-
Notifications
You must be signed in to change notification settings - Fork 328
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add RafaelJohn9 as a contributor #262
Conversation
Congratulations on completing Chapter 5 of the Intro to OSS Course with your contribution to this repository @RafaelJohn9! You're almost to the end of the course. Create a highlight of your contribution to our guestbook using the instructions in chapter 6 and share it with us! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @RafaelJohn9,
Thank you for your PR! 🙌
However, please complete your PR form so we can understand and review the changes you made.
Can you please:
- make sure you fill all the areas in the form,
- provide a description of the changes that you made in the "Description" section.
Also, you don't have issue assigned.
You can create an issue by following step 1 in the Getting Started section on the course and link the number of the issue in the "Related Issue" section.
We're only reviewing and accepting this PR once we get all the information needed.
Please let us know once you've completed the form.
Thank you. 🙂
@adiati98 I have fixed the issue |
Hey @RafaelJohn9 , We have merged a PR before yours. Please resolve the conflicts before we can review and merge yours. Also, please be noticed that the number that you mentioned in the "Related Issue" section is your PR number and not your issue number. You don't have any issue that accompanying this PR. So you can leave an "N/A" here. :) Do let us know if you need any help. Thanks. 😊 |
on it |
@adiati98 its done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Line 39 in the readme should also be updating:
[![All Contributors](https://img.shields.io/badge/all_contributors-121-orange.svg?style=flat-square)](#contributors-)
Have you run npm run contributors:generate
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Compliance Checks Passed!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @RafaelJohn9,
I've helped you run the generate command to increase the badge and generate your profile on README in your PR. ✨
Please pay attention to step 3 in this section about how to resolve conflicts. For your future contributions reference, you need to read instructions in any guidelines thoroughly.
I've also created an issue (#312) to accompany this PR. You can read this blog post about the importance of having an issue when contributing to open source projects.
If you haven't, you can join our community Discord. 😊
Also, check out our pizza-verse repo if you want to contribute further! 🍕
Description
I have added a new contributor (me) as per the open-sauced guide that closes the
What type of PR is this? (check all applicable)
Related Issues
Closes #312
Contributors Checklist
I've read through the Getting Started section.
Have you run
npm run contributors:generate
to generate your profile and the badge on the README?Added to documentation?
Screenshot (Required for PR Review)
[optional] What GIF best describes this PR or how it makes you feel?