feat: WIP organize extensions #853
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #853 +/- ##
==========================================
+ Coverage 99.70% 99.79% +0.09%
==========================================
Files 13 15 +2
Lines 337 495 +158
Branches 85 131 +46
==========================================
+ Hits 336 494 +158
Misses 1 1 ☔ View full report in Codecov by Sentry. |
zcstarr
force-pushed
the
feat/extensions
branch
from
0e9176a to
4162560
Compare
zcstarr
force-pushed
the
feat/extensions
branch
from
4162560 to
8450a1d
Compare
shanejonas
reviewed
Dec 2, 2024
shanejonas
reviewed
Dec 2, 2024
A brief note this change limits the applicaton of extensions to the top level fields of the open rpc document, this is done as a first step towards extension support and to limit extension scope and concerns for producers and consumers
shanejonas
reviewed
Jan 16, 2025
This extends support for nested extensions that follow the same pattern as defining an extension on a definition within the spec. This allows for support for things like ContentDescriptors within parameters, and other arrayed/nested elements.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP to start organizing the code for extensions to act as a pathway to upgradeability for the open-rpc spec