-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix pit crew missing models and authorship logic #522
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Luca Della Vedova <lucadv@intrinsic.ai>
Signed-off-by: Luca Della Vedova <lucadv@intrinsic.ai>
Signed-off-by: Luca Della Vedova <lucadv@intrinsic.ai>
Signed-off-by: Luca Della Vedova <lucadv@intrinsic.ai>
Signed-off-by: Luca Della Vedova <lucadv@intrinsic.ai>
Signed-off-by: Luca Della Vedova <lucadv@intrinsic.ai>
Signed-off-by: Luca Della Vedova <lucadv@intrinsic.ai>
Signed-off-by: Luca Della Vedova <lucadv@intrinsic.ai>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the detailed explanation of all the problems and their fixes, that really helped give context for all the surrounding Python code.
Signed-off-by: Luca Della Vedova <lucadv@intrinsic.ai>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if there's a way to test the changes without a risk of breaking something for users out there.
What if we upload some empty model to both the openrobotics fuel org and the open-rmf fuel org with the same name and build a test map that contains the model?
Bug fix
Fixed bug
Ref open-rmf/rmf#578 (comment), fuel pipeline wasn't used for some time, but while fixing it I bumped into several other issues that I bundled in this PR.
Fix applied
A series of issues in pit_crew:
pit_crew
will report it as downloadable, the pipeline will later try to download it but fail. Fixed thedownloadable
generation logic d392b76.(False, None)
actually evaluates to True, fixed in 8c3f40c.ign
instead ofgz
which doesn't exist anymore, 1e6c04e for the command and 14ee953 to fix the cache folder.max()
on an empty list, change it to a more informative exception.All off this surfaced because of the following sequence of events:
Open-RMF
organization.Open-RMF/TeleportIngestor
plugin, maps still requireOpenRobotics/TeleportIngestor
.OpenRobotics/TeleportIngestor
map toOpen-RMF/TeleportIngestor
.http
pipeline fails, but the faulty boolean condition check makes the pipeline progress as usualfuel
pipeline has the correct check and aborts early.All of these will be fixed by the above.
Note however, that
TeleportIngestor
andTeleportDispenser
might be downloaded by fuel in the future, but I'll leave a detailed comment for this in the rmf_demos PR that introduces this risk open-rmf/rmf_demos#272