Add mutex to lane parameters #477
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Luca Della Vedova <lucadv@intrinsic.ai>
Signed-off-by: Luca Della Vedova <lucadv@intrinsic.ai>
mxgrey
approved these changes
Nov 13, 2023
mxgrey
pushed a commit
that referenced
this pull request
Dec 15, 2023
Signed-off-by: Luca Della Vedova <lucadv@intrinsic.ai>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New feature implementation
Implemented feature
This PR adds a new string parameter to lane parameters called
mutex.Implementation description
I briefly investigated making this an effectively optional property added through clicking the
Add Propertybutton but that turned out to be a lot more involved than expected sinceAdd Propertyhas historically only been used for vertex properties and it has vertex logic quite built-in, so the refactor would have been a lot larger.I found a small duplicated snippet when parsing speed limit so took the chance to remove it. The parameter was being added twice in the same code block.