Fix: Replace pkg_resources with importlib.resources
#395
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Importing `pkg_resources` causes errors on recent Python. The functionality we use is available as `import.resources.files` since Python 3.9; for Python 3.7 and 3.8, the backport `import_resources` is used; for Python ≤3.6, the old implementation with `pkg_resources` is used.
alcrene
changed the title
pkg_resources with importlib.resourcespkg_resources with importlib.resources
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Importing
pkg_resourcescauses errors on recent Python. The functionality we use is now available asimport.resources.filessince Python 3.9.For Python 3.7 and 3.8, this commit uses the
import_resourcesbackport, and for Python ≤3.6, the old implementation withpkg_resourcesis kept.