Fix a different in interface between NTParameterSet and the other ParameterSet classes #372
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ameterSet classes. NTParameterSet inherits from dict, and so `ps.values` is a function. In the other classes, `ps.values` was a dictionary. Here I've renamed `ps.values` to `ps._values`, and implemented `ps.items()` to match the behaviour of dict.
apdavison
force-pushed
the
fix-parameters
branch
from
7bcf108 to
c930d3c
Compare
|
I reviewed this PR and it is a good idea to rename ps.values to ps._values. But ps.items might be not necessary, because ps.as_dict appears a similar method to ps.items. |
babsey
reviewed
Sep 12, 2017
| @@ -108,6 +108,9 @@ def parse_command_line_parameter(self, p): | |||
| def diff(self, other): | |||
| return _dict_diff(self, other) | |||
|
|
|||
| def items(self): | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NTParameterSet inherits from dict, and so
ps.valuesis a function. In the other classes,ps.valueswas a dictionary. Here I've renamedps.valuestops._values, and implementedps.items()to match the behaviour of dict.