mega fix for new selector handling + accessor interface alignment + tests #918
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mandelsoft
force-pushed
the
selectors
branch
from
193256d to
79edf28
Compare
mandelsoft
force-pushed
the
selectors
branch
from
79edf28 to
fd29869
Compare
mandelsoft
force-pushed
the
selectors
branch
from
fd29869 to
9538151
Compare
Skarlso
previously approved these changes
Sep 11, 2024
Skarlso
previously approved these changes
Sep 11, 2024
mandelsoft
force-pushed
the
selectors
branch
2 times, most recently
from
1a8d622 to
2582525
Compare
Skarlso
approved these changes
Sep 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
The reworked selector framework has major issues.
Which issue(s) this PR fixes