New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Verify/markdown #871

Merged

hilmarf merged 52 commits into main from verify/markdown

Aug 20, 2024

Member

hilmarf commented Aug 12, 2024

What this PR does / why we need it:

Which issue(s) this PR fixes:

partially fixes #836

hilmarf added 3 commits

August 12, 2024 17:33


          new GHA workflow

dcc5b3a


          config files

5b7272f


          fix one first finding

hilmarf added this to the 2024-Q3 milestone

github-actions bot added the size/s label

Contributor

github-actions bot commented Aug 12, 2024 •

edited

Loading

Mend Scan Summary: ❌

Repository: open-component-model/ocm

VIOLATION DESCRIPTION	NUMBER OF VIOLATIONS
HIGH/CRITICAL SECURITY VULNERABILITIES	4
MAJOR UPDATES AVAILABLE	0
LICENSE REQUIRES REVIEW	3
HIGH RISK LICENSES	10
RESTRICTIED LICENSE FOR ON-PREMISE DELIVERY	0

Detailed Logs: mend-scan-> Generate Report
Mend UI

Contributor

ocmbot bot commented Aug 12, 2024

Integration Tests for 9e88aea run with result: Success ✅!

hilmarf added 2 commits

August 13, 2024 12:53


          Spellcheck

dd972db


          md lint

ed2d1b0

github-actions bot added size/l and removed size/s labels

Contributor

ocmbot bot commented Aug 13, 2024

Integration Tests for 9e88aea run with result: Success ✅!


          fix some lint issues

162d082

Contributor

ocmbot bot commented Aug 14, 2024

Integration Tests for 9e88aea run with result: Success ✅!


          more expressive GHA job names

02547f7

Contributor

ocmbot bot commented Aug 14, 2024

Integration Tests for 9e88aea run with result: Success ✅!

hilmarf added 8 commits

August 14, 2024 12:23


          fix links

cb10408


          fix lint and link issues

d6fc3fc


          fix more links

336ee82


          podinfo

558fd51


          fix links

a4d37bc


          trying to fix some linter issues

ae28f0c


          generate lib/tour

985cd6f


          generate docs

f9caf2d

Contributor

ocmbot bot commented Aug 14, 2024

Integration Tests for 9e88aea run with result: Success ✅!

hilmarf added 3 commits

August 15, 2024 08:35


          markdown code block supported languages:

https://github.com/jincheng9/markdown_supported_languages?tab=readme-ov-file#heres-a-full-list-of-supported-languages


          lint + links

660a950


          ignore sigstore.dev

frewilhelm reviewed

View reviewed changes

README.md Show resolved Hide resolved

README.md Show resolved Hide resolved


          fix more links

5f2d34f

hilmarf added 4 commits

August 16, 2024 15:54


          it's only: <CMD>ocm bootstrap package</CMD>

c3d0963


          minus missing

85bfe40


          generate

5b78a78


          Merge branch 'doc' into verify/markdown

d5b0fc8

Contributor

ocmbot bot commented Aug 16, 2024

Integration Tests for 6781abe run with result: Success ✅!

hilmarf added 2 commits

August 16, 2024 16:27


          wrong place?

8223a4a


          Merge branch 'main' into verify/markdown

6b48c86

Member Author

hilmarf commented Aug 16, 2024

yeay!!! all links are working!!! everthing is green now :-)
have a nice weekend!

Contributor

ocmbot bot commented Aug 16, 2024

Integration Tests for b7bbce4 run with result: Success ✅!

hilmarf unassigned mandelsoft

frewilhelm previously approved these changes

View reviewed changes

Contributor

frewilhelm left a comment

We should wait for input on #871 (comment), but otherwise the PR lgtm


          removed, because we're using github issues instead

34112d3

hilmarf dismissed frewilhelm’s stale review via

34112d3

August 19, 2024 09:13


          Merge branch 'main' into verify/markdown

675a283

Contributor

ocmbot bot commented Aug 19, 2024

Integration Tests for 8cab5fe run with result: Success ✅!


          case insensitive

Contributor

ocmbot bot commented Aug 19, 2024

Integration Tests for 8cab5fe run with result: Success ✅!

hilmarf mentioned this pull request

enable: markdown lint + check: links + spelling open-component-model/ocm-website#308

Merged


          clarified with Gerald

8b9a62e

hilmarf requested a review from frewilhelm

August 20, 2024 08:43

hilmarf enabled auto-merge (squash)

August 20, 2024 08:43

frewilhelm approved these changes

View reviewed changes

hilmarf dismissed n-boshnakov’s stale review

August 20, 2024 08:46

changes are done

Contributor

ocmbot bot commented Aug 20, 2024

Integration Tests for 8cab5fe run with result: Success ✅!

hilmarf merged commit 3963942 into main

19 checks passed

hilmarf deleted the verify/markdown branch

August 20, 2024 08:53

hilmarf linked an issue

that may be closed by this pull request

Link to integration test report does not work #835

Closed

hilmarf mentioned this pull request

Link to integration test report does not work #835

Closed

hilmarf linked an issue

that may be closed by this pull request

Add GitHub action to check markdown files for broken links open-component-model/ocm-project#214

Closed

morri-son added a commit to open-component-model/ocm-website that referenced this pull request


          enable: markdown lint + check: links + spelling (#308)

19218cb

#### What this PR does / why we need it:

This better public relation, when all links are working and there are no
typing errors.

#### Which issue(s) this PR fixes:

Some of the issues will be fixed as soon as
open-component-model/ocm#871 is merged.

---------

Co-authored-by: Gerald Morrison <67469729+morri-son@users.noreply.github.com>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size/l