Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Package restructuring #784

Merged
merged 2 commits into from
Aug 5, 2024
Merged

Package restructuring #784

merged 2 commits into from
Aug 5, 2024

Conversation

mandelsoft
Copy link
Contributor

@mandelsoft mandelsoft commented May 29, 2024

Description

Restructure the ocm core library according to the intended new package structure and module name (ocm.software/ocm).
In a first step we keep the lib and the CLI inthe same repository as before.

The actual first migration step has been be done based on the original main branch just
by calling migrate.sh --paths --module from the repository root folder. It can be repeated for new main versions.

Afterwards it is possible to call

  • make build
  • make generate
  • make test
  • make generate-deepcopy
  • go fmt ./{api,cmds}/...
  • make check

These commands should succeed.

This is the current state. Everything else is not yet done.
So far, packages are moved and renamed to their intended location in the package structure.
The used relative paths should be adapted and tests and component builds are running.

To adapt projects using this library a migration script is provided.
It can be run in in the root folder of using repositories by calling migrate.sh --script migrate.mig.
Optionally, particular package folders can be given as additional arguments.

(see also mig.md)

What type of PR is this? (check all applicable)

  • 🍕 Feature
  • 🎇 Restructuring
  • 🐛 Bug Fix
  • 📝 Documentation Update
  • 🎨 Style
  • 🧑‍💻 Code Refactor
  • 🔥 Performance Improvements
  • ✅ Test
  • 🤖 Build
  • 🔁 CI
  • 📦 Chore (Release)
  • ⏩ Revert

Related Tickets & Documents

Copy link
Contributor

This PR exceeds the recommended size of 10000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

@mandelsoft mandelsoft requested review from fabianburth and hilmarf May 29, 2024 16:24
Copy link
Contributor

github-actions bot commented May 29, 2024

Mend Scan Summary: ❌

Repository: open-component-model/ocm

VIOLATION DESCRIPTION NUMBER OF VIOLATIONS
HIGH/CRITICAL SECURITY VULNERABILITIES 3
MAJOR UPDATES AVAILABLE 0
LICENSE REQUIRES REVIEW 2
HIGH RISK LICENSES 10
RESTRICTIED LICENSE FOR ON-PREMISE DELIVERY 0

Detailed Logs: mend-scan-> Generate Report
Mend UI

@mandelsoft mandelsoft requested review from morri-son and Skarlso May 29, 2024 16:24
Copy link
Contributor

ocmbot bot commented May 29, 2024

Integration Tests for 862458c run with result: Success ✅!

Copy link
Contributor

github-actions bot commented Jun 4, 2024

This PR exceeds the recommended size of 10000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

Copy link
Contributor

ocmbot bot commented Jun 4, 2024

Integration Tests for 49a79ea run with result: Success ✅!

Copy link
Contributor

github-actions bot commented Jun 4, 2024

This PR exceeds the recommended size of 10000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

Copy link
Contributor

ocmbot bot commented Jun 4, 2024

Integration Tests for 49a79ea run with result: Success ✅!

@mandelsoft mandelsoft force-pushed the restruct branch 2 times, most recently from 00955c0 to 1cbbc16 Compare June 4, 2024 15:28
Copy link
Contributor

ocmbot bot commented Jun 4, 2024

Integration Tests for 1ba6e56 run with result: Success ✅!

Copy link
Contributor

ocmbot bot commented Jun 7, 2024

Integration Tests for e76ec98 run with result: Success ✅!

Copy link
Contributor

This PR exceeds the recommended size of 10000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

Copy link
Contributor

ocmbot bot commented Jun 25, 2024

Integration Tests for 02592a6 run with result: Success ✅!

Copy link
Contributor

github-actions bot commented Jul 9, 2024

This PR exceeds the recommended size of 10000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

Copy link
Contributor

ocmbot bot commented Jul 9, 2024

Integration Tests for 5830454 run with result: Success ✅!

Copy link
Contributor

This PR exceeds the recommended size of 10000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

Copy link
Contributor

ocmbot bot commented Jul 10, 2024

Integration Tests for 5830454 run with result: Success ✅!

Copy link
Contributor

ocmbot bot commented Jul 31, 2024

Integration Tests for d117e69 run with result: Success ✅!

@mandelsoft mandelsoft force-pushed the restruct branch 2 times, most recently from 5994168 to 9edec24 Compare August 1, 2024 07:43
Copy link
Contributor

ocmbot bot commented Aug 1, 2024

Integration Tests for d117e69 run with result: Success ✅!

Copy link
Contributor

ocmbot bot commented Aug 1, 2024

Integration Tests for d117e69 run with result: Success ✅!

Copy link
Contributor

ocmbot bot commented Aug 2, 2024

Integration Tests for 98e3650 run with result: Success ✅!

Copy link
Contributor

ocmbot bot commented Aug 5, 2024

Integration Tests for 8472909 run with result: Success ✅!

@mandelsoft mandelsoft marked this pull request as ready for review August 5, 2024 14:42
@mandelsoft mandelsoft merged commit 4a1aa4f into main Aug 5, 2024
15 of 16 checks passed
@mandelsoft mandelsoft deleted the restruct branch August 5, 2024 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🔒Closed
Development

Successfully merging this pull request may close these issues.

2 participants