Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Follow Up To Maven Access #781

Merged
merged 13 commits into from
May 28, 2024
Merged

Follow Up To Maven Access #781

merged 13 commits into from
May 28, 2024

Conversation

fabianburth
Copy link
Contributor

@fabianburth fabianburth commented May 28, 2024 •
edited by hilmarf
Loading

Description

This Pull Request is a follow up to the Pull Request adding a Maven Access Method. This Pull Request adds a corresponding input type, a blob access and corresponding helper methods in the elements package (and therefore makes several adjustments).

Please include a summary of the changes and the related issue. Please also include relevant motivation and context. List any dependencies that are required for this change.

What type of PR is this? (check all applicable)

  • 🍕 Feature
  • 🎇 Restructuring
  • 🐛 Bug Fix
  • 📝 Documentation Update
  • 🎨 Style
  • 🧑‍💻 Code Refactor
  • 🔥 Performance Improvements
  • ✅ Test
  • 🤖 Build
  • 🔁 CI
  • 📦 Chore (Release)
  • ⏩ Revert

Related Tickets & Documents

open-component-model/ocm-project#189

Added tests?

  • 👍 yes
  • 🙅 no, because they aren't needed
  • 🙋 no, because I need help
  • Separate ticket for tests # (issue/pr)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@fabianburth fabianburth added the area/ipcei Important Project of Common European Interest label May 28, 2024
@fabianburth fabianburth requested a review from mandelsoft May 28, 2024 08:14
hilmarf
hilmarf reviewed May 28, 2024
View reviewed changes
pkg/utils/tarutils/pack.go Outdated Show resolved Hide resolved
hilmarf
hilmarf reviewed May 28, 2024
View reviewed changes
pkg/maven/utils.go Outdated Show resolved Hide resolved
@hilmarf hilmarf added this to the 2024-Q2 milestone May 28, 2024
hilmarf
hilmarf previously requested changes May 28, 2024
View reviewed changes
Copy link
Member

@hilmarf hilmarf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should have only one place for such large amount of test-files

@mandelsoft mandelsoft requested a review from hilmarf May 28, 2024 17:32
@fabianburth
Copy link
Contributor Author

we should have only one place for such large amount of test-files

I resolved this change request. All packages now use the same testdata (in pkg/maven/maventest).

@fabianburth fabianburth dismissed hilmarf’s stale review May 28, 2024 17:36

We want to merge and resolved the requested issue!

@fabianburth fabianburth merged commit 509ba89 into open-component-model:main May 28, 2024
14 checks passed
@fabianburth fabianburth deleted the java branch May 28, 2024 17:37
@hilmarf hilmarf linked an issue May 29, 2024 that may be closed by this pull request
Input Type for Maven Access open-component-model/ocm-project#189
Closed
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mandelsoft mandelsoft mandelsoft approved these changes

@hilmarf hilmarf Awaiting requested review from hilmarf

Assignees
No one assigned
Labels
area/ipcei Important Project of Common European Interest
Projects
OCM Backlog Board
Status: 🔒Closed
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Input Type for Maven Access
3 participants
@fabianburth @mandelsoft @hilmarf