Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

let's get rid of reuse PendingDeprecationWarning #765

Merged
merged 19 commits into from
May 8, 2024
Merged

let's get rid of reuse PendingDeprecationWarning #765

merged 19 commits into from
May 8, 2024

Conversation

hilmarf
Copy link
Member

@hilmarf hilmarf commented May 6, 2024 •
edited
Loading

Description

Copyright and licensing information for 'xyz.go' has been found in both 'xyz.go' and in the DEP5 file located at '.reuse/dep5'.

You might want to take a look at the individual commits.

What type of PR is this? (check all applicable)

  • 🍕 Feature
  • 🎇 Restructuring
  • 🐛 Bug Fix
  • 📝 Documentation Update
  • 🎨 Style
  • 🧑‍💻 Code Refactor
  • 🔥 Performance Improvements
  • ✅ Test
  • 🤖 Build
  • 🔁 CI
  • 📦 Chore (Release)
  • ⏩ Revert

Related Tickets & Documents

  • Related Issue # (issue)
  • Closes # (issue)
  • Fixes # (issue)

Remove if not applicable

Screenshots

Added tests?

  • 👍 yes
  • 🙅 no, because they aren't needed
  • 🙋 no, because I need help
  • Separate ticket for tests # (issue/pr)

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Added to documentation?

  • 📜 README.md
  • 🙅 no documentation needed

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@github-actions github-actions bot added the size/l Large label May 6, 2024
@hilmarf hilmarf added this to the 2024-Q2 milestone May 6, 2024
@hilmarf hilmarf marked this pull request as ready for review May 6, 2024 11:32
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 6, 2024 •
edited
Loading

Mend Scan Summary: ❌

Repository: open-component-model/ocm

VIOLATION DESCRIPTION NUMBER OF VIOLATIONS
HIGH/CRITICAL SECURITY VULNERABILITIES 1
MAJOR UPDATES AVAILABLE 0
LICENSE REQUIRES REVIEW 4
HIGH RISK LICENSES 9
RESTRICTIED LICENSE FOR ON-PREMISE DELIVERY 0

Detailed Logs: mend-scan-> Generate Report
Mend UI

@ocmbot OCMBot
Copy link
Contributor

ocmbot bot commented May 6, 2024

Integration Tests for 4473dac run with result: Success ✅!

@ocmbot OCMBot
Copy link
Contributor

ocmbot bot commented May 6, 2024

Integration Tests for 4473dac run with result: Success ✅!

@ocmbot OCMBot
Copy link
Contributor

ocmbot bot commented May 7, 2024

Integration Tests for e05a5a0 run with result: Success ✅!

@hilmarf
gci
67e8523 
`gci write --custom-order --skip-generated -s standard -s blank -s dot
-s default -s localmodule`
@ocmbot OCMBot
Copy link
Contributor

ocmbot bot commented May 7, 2024

Integration Tests for e05a5a0 run with result: Success ✅!

hilmarf added 2 commits May 7, 2024 12:03
@hilmarf
gci
6bf718b 
`gci write --custom-order --skip-generated -s standard -s blank -s dot
-s default -s "Prefix(github.com/open-component-model/ocm)"`
@hilmarf
comment on gci
c087f87
@ocmbot OCMBot
Copy link
Contributor

ocmbot bot commented May 7, 2024

Integration Tests for e05a5a0 run with result: Success ✅!

@ocmbot OCMBot
Copy link
Contributor

ocmbot bot commented May 7, 2024

Integration Tests for e05a5a0 run with result: Success ✅!

@ocmbot OCMBot
Copy link
Contributor

ocmbot bot commented May 7, 2024

Integration Tests for e05a5a0 run with result: Success ✅!

@hilmarf hilmarf requested a review from Skarlso May 8, 2024 12:52
@Skarlso
Copy link
Contributor

Skarlso commented May 8, 2024

Good riddance! :DDDD

Skarlso
Skarlso previously approved these changes May 8, 2024
View reviewed changes
@hilmarf hilmarf requested a review from Skarlso May 8, 2024 13:01
@hilmarf hilmarf enabled auto-merge (squash) May 8, 2024 13:03
@ocmbot OCMBot
Copy link
Contributor

ocmbot bot commented May 8, 2024

Integration Tests for 7f589f7 run with result: Success ✅!

@hilmarf hilmarf merged commit b44a489 into main May 8, 2024
15 checks passed
@hilmarf hilmarf deleted the reuse branch May 8, 2024 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Skarlso Skarlso Skarlso approved these changes

@mandelsoft mandelsoft Awaiting requested review from mandelsoft

@fabianburth fabianburth Awaiting requested review from fabianburth

@morri-son morri-son Awaiting requested review from morri-son

@morrison-sap morrison-sap Awaiting requested review from morrison-sap

Assignees
No one assigned
Labels
size/l Large
Projects
OCM Backlog Board
Status: 🔒Closed
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hilmarf @Skarlso