Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Maven/access #721

Closed
wants to merge 34 commits into from
Closed

Maven/access #721

wants to merge 34 commits into from

Conversation

hilmarf
Copy link
Member

@hilmarf hilmarf commented Apr 10, 2024 •
edited
Loading

Description

Let's assume you have the following component-constructor.yaml:

name: acme.org/foo/bar
version: 0.0.1
provider:
  name: acme.org
resources:
  - name: java-sap-vcap-services
    type: mvnArtifact # new TYPE!
    version: 0.0.1
    access:
      type: mvn # new TYPE!
      repository: https://repo1.maven.org/maven2
      groupId: com.sap.cloud.environment.servicebinding
      artifactId: java-sap-vcap-services
      version: 0.10.4

The you can now create a component version:

ocm add componentversions --create -F ./ctf component-constructor.yaml

And you can transfer it to any other Maven repository:

ocm transfer cv -V ./ctf ./target --uploader 'ocm/mvnArtifact="Url":"https://my.maven.repository.acme.org/artifactory/ocm-mvn-test"}'

You might need to configure proper credentials in your ~/.ocmconfig:

type: generic.config.ocm.software/v1
configurations:
  - type: credentials.config.ocm.software
    consumers:
      - identity:
          type: Repository.maven.apache.org
          hostname: int.repositories.cloud.sap
          path: artifactory/ocm-mvn-test
        credentials:
          - type: Credentials
            properties:
              username: 'my-user'
              password: 'top-secret'

What type of PR is this? (check all applicable)

  • 🍕 Feature
  • 🐛 Bug Fix
  • 📝 Documentation Update
  • 🎨 Style
  • 🧑‍💻 Code Refactor
  • 🔥 Performance Improvements
  • ✅ Test
  • 🤖 Build
  • 🔁 CI
  • 📦 Chore (Release)
  • ⏩ Revert

Related Tickets & Documents

  • Related Issue # (issue)
  • Closes # (issue)
  • Fixes # (issue)

Remove if not applicable

Screenshots

Added tests?

  • 👍 yes
  • 🙅 no, because they aren't needed
  • 🙋 no, because I need help
  • Separate ticket for tests # (issue/pr)

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Added to documentation?

  • 📜 README.md
  • 🙅 no documentation needed

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@hilmarf hilmarf self-assigned this Apr 10, 2024
@hilmarf hilmarf added this to the 2024-Q2 milestone Apr 10, 2024
@github-actions github-actions bot added the size/l Large label Apr 10, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 10, 2024 •
edited
Loading

Mend Scan Summary: ❌

Repository: open-component-model/ocm

VIOLATION DESCRIPTION NUMBER OF VIOLATIONS
HIGH/CRITICAL SECURITY VULNERABILITIES 0
MAJOR UPDATES AVAILABLE 0
LICENSE REQUIRES REVIEW 4
HIGH RISK LICENSES 9
RESTRICTIED LICENSE FOR ON-PREMISE DELIVERY 0

Detailed Logs: mend-scan-> Generate Report
Mend UI

This was linked to issues Apr 10, 2024
EPIC: Enhance OCM CLI with additional uploaders open-component-model/ocm-project#170
Closed
Add "maven" uploader open-component-model/ocm-project#28
Closed
@ocmbot OCMBot
Copy link
Contributor

ocmbot bot commented Apr 10, 2024

Integration Tests for 4a026de run with result: Success ✅!

@ocmbot OCMBot
Copy link
Contributor

ocmbot bot commented Apr 10, 2024

Integration Tests for 4a026de run with result: Success ✅!

@ocmbot OCMBot
Copy link
Contributor

ocmbot bot commented Apr 10, 2024

Integration Tests for 4a026de run with result: Success ✅!

@ocmbot OCMBot
Copy link
Contributor

ocmbot bot commented Apr 11, 2024

Integration Tests for 4a026de run with result: Success ✅!

@ocmbot OCMBot
Copy link
Contributor

ocmbot bot commented Apr 12, 2024

Integration Tests for 4a026de run with result: Success ✅!

hilmarf
hilmarf commented Apr 12, 2024
View reviewed changes
pkg/contexts/ocm/accessmethods/mvn/method_test.go Outdated
Comment on lines 78 to 80
<*fmt.wrapError | 0xc0008f2240>:
unable to read access: unable to create temporary file: mkdir C:\SAPDEV~1\TEMP\user: lstat /C:: CreateFile C:/SAPDEV~1/TEMP/user/VFS-1551776656/C:: The filename, directory name, or volume label syntax is incorrect.
msg: "unable to create temporary file: mkdir C:\\SAPDEV~1\\TEMP\\user: lstat /C:: CreateFile C:/SAPDEV~1/TEMP/user/VFS-1551776656/C:: The filename, directory name, or volume label syntax is incorrect."
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mandelsoft - any idea, what's going on here?

@ocmbot OCMBot
Copy link
Contributor

ocmbot bot commented Apr 12, 2024

Integration Tests for 4a026de run with result: Success ✅!

@ocmbot OCMBot
Copy link
Contributor

ocmbot bot commented Apr 12, 2024

Integration Tests for 4a026de run with result: Success ✅!

@hilmarf hilmarf marked this pull request as ready for review April 15, 2024 10:53
@hilmarf hilmarf requested a review from mandelsoft April 15, 2024 10:53
@ocmbot OCMBot
Copy link
Contributor

ocmbot bot commented Apr 15, 2024

Integration Tests for f44a710 run with result: Success ✅!

@ocmbot OCMBot
Copy link
Contributor

ocmbot bot commented Apr 15, 2024

Integration Tests for f44a710 run with result: Success ✅!

@ocmbot OCMBot
Copy link
Contributor

ocmbot bot commented Apr 17, 2024

Integration Tests for db0f39f run with result: Success ✅!

@ocmbot OCMBot
Copy link
Contributor

ocmbot bot commented Apr 18, 2024

Integration Tests for 0fc98aa run with result: Success ✅!

@hilmarf hilmarf marked this pull request as draft April 19, 2024 13:03
@ocmbot OCMBot
Copy link
Contributor

ocmbot bot commented Apr 19, 2024

Integration Tests for 3b6f0f7 run with result: Success ✅!

@hilmarf
Copy link
Member Author

hilmarf commented Apr 23, 2024

obsolete - continuing with #731 instead

@hilmarf hilmarf closed this Apr 23, 2024
@hilmarf hilmarf deleted the maven/access branch June 4, 2024 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mandelsoft mandelsoft Awaiting requested review from mandelsoft

Assignees

@hilmarf hilmarf

Labels
size/l Large
Projects
OCM Backlog Board
Status: 🔒Closed
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

EPIC: Enhance OCM CLI with additional uploaders Add "maven" uploader
1 participant
@hilmarf