Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix cd copy + rsa-pss-signingserver #670

Merged
merged 3 commits into from
Feb 22, 2024

Conversation

mandelsoft
Copy link
Contributor

@mandelsoft mandelsoft commented Feb 20, 2024

Description

Two urgend fixes:

  • The component descriptor copy function does not copy the creation timestamp.
    This leads to various problems. For example a component version might be assumed to be changed,
    even if nothing has been done.
  • fix the used signing algorithm for the rsa-pss-signingserver handler.

What type of PR is this? (check all applicable)

  • 🍕 Feature
  • 🐛 Bug Fix
  • 📝 Documentation Update
  • 🎨 Style
  • 🧑‍💻 Code Refactor
  • 🔥 Performance Improvements
  • ✅ Test
  • 🤖 Build
  • 🔁 CI
  • 📦 Chore (Release)
  • ⏩ Revert

Related Tickets & Documents

  • Related Issue # (issue)
  • Closes # (issue)
  • Fixes # (issue)

Remove if not applicable

Screenshots

Added tests?

  • 👍 yes
  • 🙅 no, because they aren't needed
  • 🙋 no, because I need help
  • Separate ticket for tests # (issue/pr)

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Added to documentation?

  • 📜 README.md
  • 🙅 no documentation needed

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@mandelsoft mandelsoft changed the title fix cd copy fix cd copy + rsa-pss-signingserver Feb 21, 2024
Copy link
Member

@hilmarf hilmarf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hilmarf hilmarf enabled auto-merge (squash) February 22, 2024 08:39
@mandelsoft mandelsoft disabled auto-merge February 22, 2024 08:39
@mandelsoft mandelsoft enabled auto-merge (squash) February 22, 2024 08:40
@mandelsoft mandelsoft disabled auto-merge February 22, 2024 08:41
@mandelsoft mandelsoft merged commit b60bac1 into open-component-model:main Feb 22, 2024
13 of 14 checks passed
@mandelsoft mandelsoft deleted the fix branch February 22, 2024 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants