Skip to content

Commit

Permalink
fix: remove helm namespace and cert-manager dependency from the helm-…
Browse files Browse the repository at this point in the history
…chart (#515)

Closes #509
  • Loading branch information
Skarlso authored Sep 23, 2024
1 parent 0ef1233 commit 5b2a63a
Show file tree
Hide file tree
Showing 13 changed files with 2 additions and 183 deletions.
7 changes: 2 additions & 5 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -431,11 +431,8 @@ To do this, use the following command:
helm install ocm-controller oci://ghcr.io/open-component-model/helm/ocm-controller --version v0.21.3
```

To optionally install cert-manager alongside with certificates configured to be ready to be used, run:

```
helm install ocm-controller oci://ghcr.io/open-component-model/helm/ocm-controller --set cert-manager.enabled=true
```
This does require that certain items, like certificate secrets are pre-created by the user.
For details, checkout the prime-test-cluster scripts under the `hack` folder.

## Uninstall

Expand Down
6 changes: 0 additions & 6 deletions deploy/Chart.lock

This file was deleted.

6 changes: 0 additions & 6 deletions deploy/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -9,9 +9,3 @@ keywords:
- ocm
- open-component-model
- kubernetes

dependencies:
- name: cert-manager
version: v1.14.5
repository: https://charts.jetstack.io
condition: cert-manager.enabled
Binary file removed deploy/charts/cert-manager-v1.14.5.tgz
Binary file not shown.
8 changes: 0 additions & 8 deletions deploy/templates/cert-manager_namespace.yaml

This file was deleted.

59 changes: 0 additions & 59 deletions deploy/templates/cluster_issuer.yaml

This file was deleted.

6 changes: 0 additions & 6 deletions deploy/templates/namespace.yaml

This file was deleted.

28 changes: 0 additions & 28 deletions deploy/templates/ocm-system_certificate.yaml

This file was deleted.

14 changes: 0 additions & 14 deletions deploy/templates/wait-for-cert-manager-role-binding.yaml

This file was deleted.

10 changes: 0 additions & 10 deletions deploy/templates/wait-for-cert-manager-role.yaml

This file was deleted.

7 changes: 0 additions & 7 deletions deploy/templates/wait-for-cert-manager-service-account.yaml

This file was deleted.

27 changes: 0 additions & 27 deletions deploy/templates/wait-for-cert-manager.yaml

This file was deleted.

7 changes: 0 additions & 7 deletions deploy/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -3,13 +3,6 @@
global:
namespace: ocm-system

cert-manager:
enabled: false
namespace: cert-manager
installCRDs: true
fullnameOverride: "cert-manager" # this is needed for the certificate issuer to not throw an unknown authority error
nameOverride: "cert-manager" # needed because otherwise it will call it `certManager`

registry:
address: registry.ocm-system.svc.cluster.local:5000
tls:
Expand Down

0 comments on commit 5b2a63a

Please sign in to comment.