Improve local only sync #87
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Job Summary for GradleBuild & Test :: build
|
opatry
force-pushed
the
improve-local-only-sync
branch
from
a215d01 to
2fa07e3
Compare
Job Summary for GradleBuild & Test :: build
|
opatry
force-pushed
the
improve-local-only-sync
branch
from
2fa07e3 to
205612f
Compare
opatry
commented
Oct 30, 2024
| @@ -223,6 +266,7 @@ class TaskRepository( | |||
| } | |||
| if (remoteTaskList != null) { | |||
| taskListDao.upsert(remoteTaskList.asTaskListEntity(localTaskList.id, localTaskList.sorting)) | |||
| taskListIds[localTaskList.id] = remoteTaskList.id | |||
There was a problem hiding this comment.
This isn't ideal for the next step as it would consider this local only list as remote from now on.
In particular, it will query its tasks which aren't there for sure…
This should be refactored another way.
opatry
force-pushed
the
improve-local-only-sync
branch
2 times, most recently
from
f674a02 to
5412239
Compare
opatry
force-pushed
the
improve-local-only-sync
branch
from
5412239 to
ac610fa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
positionsorting wasn't enforced at DB query levelChecklist