Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Part of onvim in fullscreen is visible on a second monitor #3063

Open
noahhaasis opened this issue Jan 29, 2021 · 1 comment
Open

Part of onvim in fullscreen is visible on a second monitor #3063

noahhaasis opened this issue Jan 29, 2021 · 1 comment
Labels
bug Something isn't working platform-windows Platform: Windows U-revery Upstream: Potentially dependent on changes in revery

Comments

@noahhaasis
Copy link
Contributor

When I fullscreen onivim, part of the window is visible on my second monitor. That's the small white stripe in the image.
When I fullscreen it again after louding it takes the color of the window. It's not possible to interact with these 10 pixels or so, they are just "bleeding" over.

grafik

Machine: Windows 10
@bryphe
Copy link
Member

bryphe commented Feb 1, 2021

Thanks for logging the issue, @noahhaasis - I think this is the same underlying issue @vhanla mentioned here: revery-ui/revery#1001

@bryphe bryphe added bug Something isn't working U-revery Upstream: Potentially dependent on changes in revery platform-windows Platform: Windows labels Feb 1, 2021
This was referenced Feb 2, 2021
Open
Open
@bryphe bryphe mentioned this issue Jul 14, 2021
Merged
4 tasks
bryphe added a commit that referenced this issue Jul 22, 2021
@bryphe
feat(windows): Customizable title bar style (#3765)
0cd8c42 
__Issue:__ There are several quirks on Windows with the 'undecorated' Windows style - issues like:
- #3730 
- #3071 
- #3063 

__Fix:__ These can be deal-breakers for use as a daily editor, so until we have those fixed for the 'undecorated' Windows, change the default setting to use the native titlebar. 

This introduces a new setting - `window.titleBarStyle` that can be `"native"` or `"custom"`. The `"custom"`  titlebar looks nicer, because it is themed and custom rendered, however it has the above quirks. On Windows, change the default to `"native"`.

In addition, this pushes up the configuration loading sooner in the startup cycle, so we can pick up configuration settings like `"window.titleBarStyle"` prior to opening the window.

__Todo:__
- [x] Fix margin on Windows, based on whether we are using the decorated window or not
- [x] Test OSX
- [x] Test Windows (both settings)
- [x] Test on Linux (both settings)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working platform-windows Platform: Windows U-revery Upstream: Potentially dependent on changes in revery
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bryphe @noahhaasis