Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Window has no shadow on Windows #3071

Open
clo4 opened this issue Jan 31, 2021 · 1 comment
Open

Window has no shadow on Windows #3071

clo4 opened this issue Jan 31, 2021 · 1 comment
Labels
A-technical Area: Technical issues, like platform support and issues that don't affect most users directly A-ux Area: Overall user experience and aesthetics platform-windows Platform: Windows U-revery Upstream: Potentially dependent on changes in revery

Comments

@clo4
Copy link

clo4 commented Jan 31, 2021

First noticed this around when the custom window decoration was added.

image

Minor nitpick, some apps (like Microsoft's own Office 365 suite 👀) don't fit very nicely with normal window shadows.
It'd be great if the window shadow felt native, too! :)

image
@bryphe bryphe added A-technical Area: Technical issues, like platform support and issues that don't affect most users directly A-ux Area: Overall user experience and aesthetics platform-windows Platform: Windows U-revery Upstream: Potentially dependent on changes in revery labels Feb 2, 2021
@bryphe bryphe mentioned this issue Feb 2, 2021
Open
@bryphe
Copy link
Member

bryphe commented Feb 2, 2021

Thanks for logging the issue @separaterecords - nice catch on this 👍

Indeed, it looks like the strategy for our borderless window happened to take away our drop shadow - need to investigate a strategy like in this stackoverflow post.

Related to #3063 - it might be that using the DwmExtendFrameIntoClientArea API could integrate with the proposed fix in revery-ui/revery#1001 to address both this and #3063

@bryphe bryphe mentioned this issue Jul 14, 2021
Merged
4 tasks
bryphe added a commit that referenced this issue Jul 22, 2021
@bryphe
feat(windows): Customizable title bar style (#3765)
0cd8c42 
__Issue:__ There are several quirks on Windows with the 'undecorated' Windows style - issues like:
- #3730 
- #3071 
- #3063 

__Fix:__ These can be deal-breakers for use as a daily editor, so until we have those fixed for the 'undecorated' Windows, change the default setting to use the native titlebar. 

This introduces a new setting - `window.titleBarStyle` that can be `"native"` or `"custom"`. The `"custom"`  titlebar looks nicer, because it is themed and custom rendered, however it has the above quirks. On Windows, change the default to `"native"`.

In addition, this pushes up the configuration loading sooner in the startup cycle, so we can pick up configuration settings like `"window.titleBarStyle"` prior to opening the window.

__Todo:__
- [x] Fix margin on Windows, based on whether we are using the decorated window or not
- [x] Test OSX
- [x] Test Windows (both settings)
- [x] Test on Linux (both settings)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-technical Area: Technical issues, like platform support and issues that don't affect most users directly A-ux Area: Overall user experience and aesthetics platform-windows Platform: Windows U-revery Upstream: Potentially dependent on changes in revery
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bryphe @clo4