Update Android permissions and features #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since using the camera, with CAMERA permission, already allows to use the flashlight. see https://stackoverflow.com/a/48553060
The CAMERA permission automatically requires all camera features. see https://developer.android.com/guide/topics/manifest/uses-feature-element#permissions Let app developers decide whether these are required or not, set <uses-feature> by themselves if needed, preventing conflict with other plugins here.
ath0mas
changed the title
ath0mas
force-pushed
the
android-permissions-and-features
branch
from
a4c5f78 to
5564ff2
Compare
|
@ath0mas |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FLASHLIGHTpermissionSince using the camera, with
CAMERApermission, already allows to use the flashlight.see https://stackoverflow.com/a/48553060
2. remove explicithardware.camerafeatureThe
CAMERApermission automatically requires some camera features.see https://developer.android.com/guide/topics/manifest/uses-feature-element#permissions
Let app developers decide whether these are required or not, set
<uses-feature>by themselves if needed, preventing conflict with other plugins here.hardware.camerafeatures but to disable filtering based on theCAMERApermissionThe
CAMERApermission automatically requires some camera features.see https://developer.android.com/guide/topics/manifest/uses-feature-element#permissions
Related to #7 and therefore also to phonegap#882.