Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possibility to register wordpress authenticate filter. #236

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

gassan
Copy link
Contributor

@gassan gassan commented Sep 24, 2020

All Submissions:

Changes proposed in this Pull Request:

This PR is a replacement for #130

Added authenticate_filter to allow login via a default wordpress Login form. The user is not forwarded to Provider Server.

If we are owner of both instances (a WP site and User Provider Server), we can allow the WP instance to know a user credentials - so user can login direct via Login Form.

The 'new' validate($response_token) function is not new. the functions body is moved from authentication_request_callback() and adapted to reuse with new authenticate_filter() function.

Closes # .

How to test the changes in this Pull Request:

  1. Install some provider that allows grant_type password (we are using Keycloak) and select checkbox 'Register Authenticate Filter'. Try to login with username and password.

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes, as applicable?
  • Have you successfully run tests with your changes locally?

Changelog entry

Enter a summary of all changes on this Pull Request. This will appear in the changelog if accepted.

@timnolte timnolte added enhancement Issues & PRs related to new features. status: needs changelog Mark all PRs that have not had their changelog entries added. status: needs docs Needs explanation in release notes, README, or documentation. status: needs review PR that needs review. labels Sep 24, 2020
Copy link
Collaborator

@timnolte timnolte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't alter the Pull Request Template.

@gassan gassan force-pushed the authenticate-filter branch from 3db77b7 to 0f8e767 Compare September 24, 2020 11:07
@gassan
Copy link
Contributor Author

gassan commented Apr 19, 2021

Should I review this PR. Are there any chances of merging for it?

@timnolte timnolte deleted the branch oidc-wp:develop December 23, 2023 00:56
@timnolte timnolte closed this Dec 23, 2023
@timnolte timnolte reopened this Dec 23, 2023
@timnolte timnolte changed the base branch from dev to develop December 23, 2023 01:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Issues & PRs related to new features. status: needs changelog Mark all PRs that have not had their changelog entries added. status: needs docs Needs explanation in release notes, README, or documentation. status: needs review PR that needs review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants