move GetCommPorts, add missing comm functions, add communication events #4648
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Why is this draft? It looks fine to me! |
|
@laytan I saw some pipelines fail and didn't have time to investigate. I also found some related missing functions (serial communication stuff), so I'll be pushing these as well. |
…ion event constants
lzurbriggen
changed the title
|
Ah alright, CI fails frequently at the moment so those weren't your fault |
laytan
reviewed
Jan 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Calling
GetCommPortsfromcore:sys/windowsresulted inunresolved external symbol GetCommPorts referenced in functionbecause it's provided byOneCore.liband notKernel32.lib.I'm not really familiar with low level programming and couldn't really find a good overview over
OneCore.lib(available in >=Win10 afaik), so I'm not sure if there are other functions that should be moved.I also added the missing
SetCommMask,GetCommMask,WaitCommEvent, as well as communication function constantsDocs