-
-
Notifications
You must be signed in to change notification settings - Fork 652
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Haiku: fix build and add initial core:sys/posix
support
#4603
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you also try adding haiku
to the test suite in tests/core/sys/posix
?
I guess it might not work well because it's a start on the posix package so there's still things undefined that are used there though.
Would also be great if we could get everything for os2 implemented. Currently missing a lot of symbols though.
If you don't have time for these things we can just merge this and worry about those later though, at least it will build and run on haiku again.
|
||
[[ More; https://pubs.opengroup.org/onlinepubs/9699919799/functions/sigtimedwait.html ]] | ||
*/ | ||
sigtimedwait :: proc(set: ^sigset_t, info: ^siginfo_t, timeout: ^timespec) -> result --- |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't love this, I tried making the posix package a common base where all defined procs are implemented on all targets it supports, now one could use sigtimedwait on a target expecting it to work when compiling to darwin.
I think I'd rather see it defined in the sys/haiku
package instead.
We should also look at (not here) adding CI for haiku so it can't keep breaking without us knowing it did. |
No description provided.