Internals: fix ambiguous symbol

[zMidair]

I keep getting this error and this commit will most probably fix it.

Hopefully everything is alright, otherwise please give constructive criticism.

[ocornut]

I keep getting this error

Please specify which error, on which line, which compiler, setup etc.

[zMidair]

The error is basically what I said. The reason it exists is because another library I use (unrelated to imgui) conflicts with the cmath log function used by imgui. This would be a good fix for multiple users since the “log” function name is pretty common.

[ocornut]

Please answer my question clearly. You haven’t done that.

[ocornut]

AFAIK the only place we call/use a symbol called log is there:

static inline double ImLog(double x)            { return log(x); }

for this to make a difference you would need to have included imgui_internal.h in the same compilation unit as another library.
Can you check/verify if changing the code to:

static inline double ImLog(double x)            { return ::log(x); }

Fixes your issue?

But either way, I need you to report exact errors + clarify your repro (e.g. confirm that you are including header xxx - which library? - before imgui_internal.h, or whatever you are doing). Thank you.

It's particularly difficult to blindly accept a change without details, and if the message says "will most probably fix it" it doesn't give confidence either.

[zMidair]

Alright, I'll try doing that.